https://bugzilla.redhat.com/show_bug.cgi?id=1473705
Bug ID: 1473705
Summary: Review Request: perl-Alien-Base-ModuleBuild - Perl
framework for building Alien:: modules and their
libraries
Product: Fedora
Version: rawhide
Component: Package Review
Severity: medium
Priority: medium
Assignee: nobody(a)fedoraproject.org
Reporter: ppisar(a)redhat.com
QA Contact: extras-qa(a)fedoraproject.org
CC: package-review(a)lists.fedoraproject.org
Spec URL:
https://ppisar.fedorapeople.org/perl-Alien-Base-ModuleBuild/perl-Alien-Base…
SRPM URL:
https://ppisar.fedorapeople.org/perl-Alien-Base-ModuleBuild/perl-Alien-Base…
Description:
This is a Perl base class and framework for creating Alien distributions. The
goal of the project is to make things as simple and easy as possible for both
developers and users of Alien modules.
Alien is a Perl name space for defining dependencies in CPAN for libraries and
tools which are not "native" to CPAN. Alien modules will typically use the
system libraries if they are available, or download the latest version from
the internet and build them from source code. These libraries can then be
used by other Perl modules, usually modules that are implemented with XS or
FFI.
Fedora Account System Username: ppisar
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=1463253
Matthias Runge <mrunge(a)redhat.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|ASSIGNED |POST
Flags|fedora-review? |fedora-review+
--- Comment #4 from Matthias Runge <mrunge(a)redhat.com> ---
Package Review
==============
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
Issues:
=======
- Package contains Requires: ruby(release).
===== MUST items =====
Generic:
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
Note: Using prebuilt packages
koji scratchbuild: https://koji.fedoraproject.org/koji/taskinfo?taskID=21223848
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[x]: License field in the package spec file matches the actual license.
Note: There is no build directory. Running licensecheck on vanilla
upstream sources. No licenses found. Please check the source files for
licenses manually.
[x]: All build dependencies are listed in BuildRequires, except for any
that are listed in the exceptions section of Packaging Guidelines.
Note: Using prebuilt rpms.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 40960 bytes in 4 files.
[x]: Package complies to the Packaging Guidelines
Note: for the fedora package, please remove the provides: line. I would
recommend to add a %if 0%{?fedora} .. %endif around that provides line.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
Ruby:
[x]: Platform dependent files must all go under %{gem_extdir_mri}, platform
independent under %{gem_dir}.
[x]: Gem package must not define a non-gem subpackage
[x]: Macro %{gem_extdir} is deprecated.
[x]: Gem package is named rubygem-%{gem_name}
[x]: Package contains BuildRequires: rubygems-devel.
[x]: Gem package must define %{gem_name} macro.
[x]: Pure Ruby package must be built as noarch
[x]: Package does not contain Requires: ruby(abi).
===== SHOULD items =====
Generic:
[x]: Reviewer should test that the package builds in mock.
https://koji.fedoraproject.org/koji/taskinfo?taskID=21223848
[x]: If the source package does not include license text(s) as a separate
file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[?]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[x]: Description and summary sections in the package spec file contains
translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
architectures.
[x]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
files.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
$RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Fully versioned dependency in subpackages if applicable.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.
Ruby:
[!]: Gem should use %gem_install macro.
[x]: Specfile should use macros from rubygem-devel package.
Note: The specfile doesn't use these macros: %doc
/usr/share/gems/doc/lru_redux-1.1.0,
/usr/share/gems/specifications/lru_redux-1.1.0.gemspec, %exclude
/usr/share/gems/cache/lru_redux-1.1.0.gem,
/usr/share/gems/gems/lru_redux-1.1.0/lib
[x]: Gem package should exclude cached Gem.
[x]: gems should not require rubygems package
[x]: Test suite should not be run by rake.
[x]: Test suite of the library should be run.
===== EXTRA items =====
Generic:
[!]: Spec file according to URL is the same as in SRPM.
Note: Spec file as given by url is not the same as in SRPM (see
attached diff).
See: (this test has no URL)
[x]: Rpmlint is run on all installed packages.
Note: There are rpmlint messages (see attachment).
Rpmlint
-------
Checking: rubygem-lru_redux-1.1.0-1.el7.src.rpm
rubygem-lru_redux.src: W: spelling-error Summary(en_US) lru -> URL
rubygem-lru_redux.src: W: spelling-error %description -l en_US lru -> URL
rubygem-lru_redux.src: W: non-coherent-filename
rubygem-lru_redux-1.1.0-1.el7.src.rpm
rubygem-lru_redux-1.1.0-1.el7.centos.src.rpm
1 packages and 0 specfiles checked; 0 errors, 3 warnings.
Rpmlint (installed packages)
----------------------------
Cannot parse rpmlint output:
Diff spec file in url and in SRPM
---------------------------------
--- /home/mrunge/review/rubygem-lru_redux.spec 2017-08-14 12:36:12.309952178
+0200
+++
/home/mrunge/review/review-rubygem-lru_redux/srpm-unpacked/rubygem-lru_redux.spec
2017-07-25 09:07:21.000000000 +0200
@@ -5,5 +5,5 @@
# This will enable test on the future
# and also added it depdendencies
-%global with_test 1
+%global with_test 0
Name: rubygem-%{gem_name}
@@ -20,4 +20,7 @@
%if 0%{?with_test}
BuildRequires: rubygem(minitest)
+BuildRequires: rubygem(guard-minitest)
+BuildRequires: rubygem(guard)
+BuildRequires: rubygem(rb-inotify)
BuildRequires: rubygem(timecop) >= 0.7
BuildRequires: rubygem(timecop) < 1
@@ -70,10 +73,5 @@
%check
pushd .%{gem_instdir}
-%if 0%{?with_test}
-ruby -Ilib:test test/cache_test.rb
-ruby -Ilib:test -e "load 'test/cache_test.rb'" -e "load
'test/thread_safe_cache_test.rb'"
-ruby -Ilib:test -e "load 'test/cache_test.rb'" -e "load
'test/ttl/cache_test.rb'"
-ruby -Ilib:test -e "load 'test/cache_test.rb'" -e "load
'test/ttl/cache_test.rb'" -e "load 'test/ttl/thread_safe_cache_test.rb'"
-%endif
+
popd
Requires
--------
Provides
--------
Source checksums
----------------
https://rubygems.org/gems/lru_redux-1.1.0.gem :
CHECKSUM(SHA256) this package :
ee71d0ccab164c51de146c27b480a68b3631d5b4297b8ffe8eda1c72de87affb
CHECKSUM(SHA256) upstream package :
ee71d0ccab164c51de146c27b480a68b3631d5b4297b8ffe8eda1c72de87affb
Generated by fedora-review 0.6.1 (f03e4e7) last change: 2016-05-02
Command line :/usr/bin/fedora-review -n rubygem-lru_redux -p -D DISTTAG=fc26
Buildroot used: fedora-rawhide-x86_64
Active plugins: Generic, Ruby, Shell-api
Disabled plugins: Java, C/C++, Python, fonts, SugarActivity, Ocaml, Perl,
Haskell, R, PHP
Disabled flags: EXARCH, EPEL5, BATCH, EPEL6
I was looking at the spec file at
https://raw.githubusercontent.com/jbadiapa/packages/master/rubygem-lru_redu…
Package approved.
You can go now and request a new package to be created according to [1]. Please
also add the package to RDO; for an example, see here[2]
[1]
https://fedoraproject.org/wiki/Infrastructure/WhatHappenedToPkgdb#How_do_I_…
[2] https://review.rdoproject.org/r/#/c/8379/
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=1463253
--- Comment #3 from Juan Badia Payno <jbadiapa(a)redhat.com> ---
Tests added on the spec file.
The with_test argument is still present but set to 1, to enable the
requirements and execute the tests.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=1468949
Bug ID: 1468949
Summary: Review Request: <main package name here> - <short
summary here>
Product: Fedora
Version: rawhide
Component: Package Review
Severity: medium
Priority: medium
Assignee: nobody(a)fedoraproject.org
Reporter: michel(a)michel-slm.name
QA Contact: extras-qa(a)fedoraproject.org
CC: package-review(a)lists.fedoraproject.org
Spec URL: https://salimma.fedorapeople.org/specs/python/python3-greenlet.spec
SRPM URL:
https://salimma.fedorapeople.org/specs/python/python3-greenlet-0.4.11-1.el7…
Description: Python 3 build of python-greenlet for EPEL7
The greenlet package is a spin-off of Stackless, a version of CPython
that supports micro-threads called "tasklets". Tasklets run
pseudo-concurrently (typically in a single or a few OS-level threads)
and are synchronized with data exchanges on "channels".
Fedora Account System Username: salimma
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=1480130
Bug ID: 1480130
Summary: Review Request: perl-Math-Utils - Useful mathematical
functions not in Perl
Product: Fedora
Version: rawhide
Component: Package Review
Severity: medium
Priority: medium
Assignee: nobody(a)fedoraproject.org
Reporter: jplesnik(a)redhat.com
QA Contact: extras-qa(a)fedoraproject.org
CC: package-review(a)lists.fedoraproject.org
Spec URL:
https://jplesnik.fedorapeople.org/perl-Math-Utils/perl-Math-Utils.spec
SRPM URL:
https://jplesnik.fedorapeople.org/perl-Math-Utils/perl-Math-Utils-1.10-1.fc…
Description:
Math::Utils contains implementations of commonly used mathematical
functions and operations that are not part of standard Perl.
Fedora Account System Username: jplesnik(a)redhat.com
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=1475564
Bug ID: 1475564
Summary: Review Request: python-pytest-fixture-config - Simple
configuration objects for Py.test fixtures
Product: Fedora
Version: rawhide
Component: Package Review
Severity: medium
Priority: medium
Assignee: nobody(a)fedoraproject.org
Reporter: kevin(a)scrye.com
QA Contact: extras-qa(a)fedoraproject.org
CC: package-review(a)lists.fedoraproject.org
Spec URL:
https://www.scrye.com/~kevin/fedora/review/python-pytest-fixture-config/pyt…
SRPM URL:
https://www.scrye.com/~kevin/fedora/review/python-pytest-fixture-config/pyt…
Description: Simple configuration objects for Py.test fixtures
Fedora Account System Username: kevin
rpmlint says:
3 packages and 0 specfiles checked; 0 errors, 0 warnings.
koji scratch build:
3 packages and 0 specfiles checked; 0 errors, 0 warnings.
This package is needed for python-setuptools tests.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=1468768
Bug ID: 1468768
Summary: Review Request: domoticz - Open source Home Automation
System
Product: Fedora
Version: rawhide
Component: Package Review
Severity: medium
Priority: medium
Assignee: nobody(a)fedoraproject.org
Reporter: mike(a)cchtml.com
QA Contact: extras-qa(a)fedoraproject.org
CC: package-review(a)lists.fedoraproject.org
Spec URL: http://michael.cronenworth.com/RPMS/domoticz.spec
SRPM URL: http://michael.cronenworth.com/RPMS/domoticz-3.5877-1.fc25.src.rpm
Description: Domoticz is a Home Automation System that lets you monitor and
configure various devices like: Lights, Switches, various sensors/meters like
Temperature, Rain, Wind, UV, Electra, Gas, Water and much more.
Notifications/Alerts can be sent to any mobile device
Fedora Account System Username: mooninite
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=1480956
sensor.wen(a)gmail.com changed:
What |Removed |Added
----------------------------------------------------------------------------
Blocks| |1465889
| |(DeepinDEPackageReview)
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=1465889
[Bug 1465889] Tracking: Deepin Desktop related package review tracker
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=1094057
Bug ID: 1094057
Summary: Review Request: libes - Managing an entity system in
C++
Product: Fedora
Version: rawhide
Component: Package Review
Severity: medium
Assignee: nobody(a)fedoraproject.org
Reporter: pierre(a)marijon.fr
QA Contact: extras-qa(a)fedoraproject.org
CC: package-review(a)lists.fedoraproject.org
Spec URL: http://static.pierre.marijon.fr/rpm/libes/libes.spec
SRPM URL:
http://static.pierre.marijon.fr/rpm/libes/libes-0.5.2-0.1.fc20.src.rpm
Description: Libes (Library Entity System), is an library for managing an
entity system written in C++. For more info of Entity System Paradigme you can
see http://entity-systems.wikidot.com/ .
Fedora Account System Username: natir
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component