package-review September 2017

package-review@lists.fedoraproject.org

1 participants
1637 discussions

[Bug 1444562] New: Review Request: nodejs-babel-messages - Collection of debug messages used by Babel
by bugzilla＠redhat.com 18 Sep '17

18 Sep '17

https://bugzilla.redhat.com/show_bug.cgi?id=1444562 Bug ID: 1444562 Summary: Review Request: nodejs-babel-messages - Collection of debug messages used by Babel Product: Fedora Version: rawhide Component: Package Review Assignee: nobody(a)fedoraproject.org Reporter: jsmith.fedora(a)gmail.com QA Contact: extras-qa(a)fedoraproject.org CC: package-review(a)lists.fedoraproject.org Blocks: 956806 (nodejs-reviews), 1387531 (Node-RED) Spec URL: https://jsmith.fedorapeople.org/Packaging/nodejs-babel-messages/nodejs-babe… SRPM URL: https://jsmith.fedorapeople.org/Packaging/nodejs-babel-messages/nodejs-babe… Description: Collection of debug messages used by Babel Fedora Account System Username: jsmith Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=956806 [Bug 956806] Node.js Review Tracker https://bugzilla.redhat.com/show_bug.cgi?id=1387531 [Bug 1387531] Package tracker for supporting Node-RED -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

1 7

[Bug 1442507] Review Request: nodejs-unset-value - Delete nested properties from an object using dot notation
by bugzilla＠redhat.com 18 Sep '17

18 Sep '17

https://bugzilla.redhat.com/show_bug.cgi?id=1442507 --- Comment #4 from Gwyn Ciesla <limburgher(a)gmail.com> --- (fedrepo-req-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/nodejs-unset-value -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

1 0

[Bug 1442506] Review Request: nodejs-has-value - Returns true if a value exists, false if empty
by bugzilla＠redhat.com 18 Sep '17

18 Sep '17

https://bugzilla.redhat.com/show_bug.cgi?id=1442506 --- Comment #4 from Gwyn Ciesla <limburgher(a)gmail.com> --- (fedrepo-req-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/nodejs-has-value -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

1 0

[Bug 1119081] New: Review Request: ocaml-camlp4 - Pre-Processor-Pretty-Printer for OCaml
by Red Hat Bugzilla 18 Sep '17

18 Sep '17

https://bugzilla.redhat.com/show_bug.cgi?id=1119081 Bug ID: 1119081 Summary: Review Request: ocaml-camlp4 - Pre-Processor-Pretty-Printer for OCaml Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nobody(a)fedoraproject.org Reporter: rjones(a)redhat.com QA Contact: extras-qa(a)fedoraproject.org CC: package-review(a)lists.fedoraproject.org Spec URL: http://oirase.annexia.org/reviews/camlp4/ocaml-camlp4.spec SRPM URL: http://oirase.annexia.org/reviews/camlp4/ocaml-camlp4-4.02.0-0.1.git87c6a6b… Description: camlp4 is a pre-processor and pretty printed for OCaml. Prior to OCaml 4.02 it was part of the compiler, and indeed it has been included in Fedora for aeons. However it has now moved into a separate upstream project (albeit run by exactly the same people) so it seems better to have a separate Fedora package as well. NOTES: - There are no tarballs yet, but it is expected there will be upstream releases when OCaml 4.02.0 is out of beta. - You will only be able to build this against OCaml 4.02 from Rawhide. It is not buildable against earlier versions of OCaml. Fedora Account System Username: rjones -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

2 20

[Bug 1122073] New: Review Request: ocaml-labltk - Tcl/Tk interface for OCaml
by Red Hat Bugzilla 18 Sep '17

18 Sep '17

https://bugzilla.redhat.com/show_bug.cgi?id=1122073 Bug ID: 1122073 Summary: Review Request: ocaml-labltk - Tcl/Tk interface for OCaml Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nobody(a)fedoraproject.org Reporter: rjones(a)redhat.com QA Contact: extras-qa(a)fedoraproject.org CC: package-review(a)lists.fedoraproject.org Spec URL: http://oirase.annexia.org/reviews/labltk/ocaml-labltk.spec SRPM URL: http://oirase.annexia.org/reviews/labltk/ocaml-labltk-4.02-0.1.beta1.fc20.s… Description: Tcl/Tk interface for OCaml Fedora Account System Username: rjones -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

2 12

[Bug 1028818] New: Review Request: python-pyplete - Dynamic autocompletion for Python
by Red Hat Bugzilla 18 Sep '17

18 Sep '17

https://bugzilla.redhat.com/show_bug.cgi?id=1028818 Bug ID: 1028818 Summary: Review Request: python-pyplete - Dynamic autocompletion for Python Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nobody(a)fedoraproject.org Reporter: tchollingsworth(a)gmail.com QA Contact: extras-qa(a)fedoraproject.org CC: notting(a)redhat.com, package-review(a)lists.fedoraproject.org Spec: http://patches.fedorapeople.org/kate-pate/python-pyplete.spec SRPM: http://patches.fedorapeople.org/kate-pate/python-pyplete-0.0.5-1.fc20.src.r… Koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=6163424 FAS: patches Description: PyPlete provides dynamic autocompletion for Python. It uses pysmell but unlike the standard version of it, PyPlete is dynamic, it does not need to execute a command to pre-analyze the code. It is useful for analyzing (or autocompleting) Python code. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

2 15

[Bug 1492325] Review Request: nodejs-setprototypeof - A small polyfill for Object.setprototypeof
by bugzilla＠redhat.com 17 Sep '17

17 Sep '17

https://bugzilla.redhat.com/show_bug.cgi?id=1492325 Jared Smith <jsmith.fedora(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|POST |MODIFIED --- Comment #2 from Jared Smith <jsmith.fedora(a)gmail.com> --- 'Requested package in ticket https://pagure.io/releng/fedora-scm-requests/issue/1233' -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

1 0

[Bug 1492325] Review Request: nodejs-setprototypeof - A small polyfill for Object.setprototypeof
by bugzilla＠redhat.com 17 Sep '17

17 Sep '17

https://bugzilla.redhat.com/show_bug.cgi?id=1492325 Robert-André Mauchin <zebob.m(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |POST CC| |zebob.m(a)gmail.com Assignee|nobody(a)fedoraproject.org |zebob.m(a)gmail.com Flags| |fedora-review+ --- Comment #1 from Robert-André Mauchin <zebob.m(a)gmail.com> --- Everything is okay, package accepted. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

1 0

[Bug 1481875] Review Request: python-pytest-virtualenv - Virtualenv fixture for py.test
by bugzilla＠redhat.com 17 Sep '17

17 Sep '17

https://bugzilla.redhat.com/show_bug.cgi?id=1481875 Robert-André Mauchin <zebob.m(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |POST Assignee|nobody(a)fedoraproject.org |zebob.m(a)gmail.com Flags| |fedora-review+ --- Comment #6 from Robert-André Mauchin <zebob.m(a)gmail.com> --- Everything is okay but you should query upstream for a license file. Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [-]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated". 18 files have unknown license. Detailed output of licensecheck in /home/bob/packaging/review/python-pytest- virtualenv/review-python-pytest-virtualenv/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [x]: Package does not own files or directories owned by other packages. Note: Dirs in package are owned also by: /usr/lib/python3.6/site- packages/__pycache__(python3-cycler, python3-sh, python3-libs) [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 20480 bytes in 4 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local Python: [x]: Python eggs must not download any dependencies during the build process. [x]: A package which is used by another package via an egg interface should provide egg info. [x]: Package meets the Packaging Guidelines::Python [x]: Package contains BR: python2-devel or python3-devel [x]: Binary eggs must be removed in %prep ===== SHOULD items ===== Generic: [!]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in python2 -pytest-virtualenv , python3-pytest-virtualenv [?]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: python2-pytest-virtualenv-1.2.11-2.fc28.noarch.rpm python3-pytest-virtualenv-1.2.11-2.fc28.noarch.rpm python-pytest-virtualenv-1.2.11-2.fc28.src.rpm python2-pytest-virtualenv.noarch: W: spelling-error Summary(en_US) py -> pt, p, y python2-pytest-virtualenv.noarch: W: spelling-error %description -l en_US teardown -> tear down, tear-down, downhearted python3-pytest-virtualenv.noarch: W: spelling-error Summary(en_US) py -> pt, p, y python3-pytest-virtualenv.noarch: W: spelling-error %description -l en_US teardown -> tear down, tear-down, downhearted python-pytest-virtualenv.src: W: spelling-error Summary(en_US) py -> pt, p, y python-pytest-virtualenv.src: W: spelling-error %description -l en_US teardown -> tear down, tear-down, downhearted 3 packages and 0 specfiles checked; 0 errors, 6 warnings. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

1 0

[Bug 1488101] New: Review Request: eclipse-recommenders - Eclipse Code Recommenders
by bugzilla＠redhat.com 17 Sep '17

17 Sep '17

https://bugzilla.redhat.com/show_bug.cgi?id=1488101 Bug ID: 1488101 Summary: Review Request: eclipse-recommenders - Eclipse Code Recommenders Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nobody(a)fedoraproject.org Reporter: mat.booth(a)redhat.com QA Contact: extras-qa(a)fedoraproject.org CC: package-review(a)lists.fedoraproject.org Spec URL: https://fedorapeople.org/~mbooth/reviews/eclipse-recommenders.spec SRPM URL: https://fedorapeople.org/~mbooth/reviews/eclipse-recommenders-2.4.9-1.fc28.… Description: Code Recommenders automatically analyzes existing code using APIs and extracts common usage rules and patterns from it. In the form of recommendation models, this knowledge is then fed back into your IDE. Code Recommenders’ intelligent code completion and augmented API documentation then utilizes the power of these models to provide you with the solutions implemented by other developers in the past. This helps you to get up to speed with the new framework or API without countless hours of searching the Internet for the solutions to common problems. Fedora Account System Username: mbooth Koji scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=21645907 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

1 10

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

package-review September 2017