package-review May 2021

package-review@lists.fedoraproject.org

1 participants
710 discussions

[Bug 1960858] New: Review Request: maui-mauikit- Kit for developing Maui Apps
by bugzilla＠redhat.com 17 May '21

17 May '21

https://bugzilla.redhat.com/show_bug.cgi?id=1960858 Bug ID: 1960858 Summary: Review Request: maui-mauikit- Kit for developing Maui Apps Product: Fedora Version: rawhide Hardware: All OS: Linux Status: NEW Component: Package Review Severity: medium Assignee: nobody(a)fedoraproject.org Reporter: thunderbirdtr(a)fedoraproject.org QA Contact: extras-qa(a)fedoraproject.org CC: package-review(a)lists.fedoraproject.org Target Milestone: --- Classification: Fedora Spec URL: https://pagure.io/Maukit-Packages/blob/main/f/maui-mauikit/maui-mauikit.spec SRPM URL: https://pagure.io/Maukit-Packages/blob/main/f/maui-mauikit/maui-mauikit-1.2… Description: Kit for developing MAUI Apps. MauiKit is a set of utilities and "templated" controls based on Kirigami and QCC2 that follow the ongoing work on the Maui HIG. It let you quickly create a Maui application and access utilities and widgets shared amoing the other Maui apps. Fedora Account System Username: thunderbirdtr -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

1 11

[Bug 1960823] New: Review Request: keysmith - OTP client for Plasma Mobile and Desktop
by bugzilla＠redhat.com 17 May '21

17 May '21

https://bugzilla.redhat.com/show_bug.cgi?id=1960823 Bug ID: 1960823 Summary: Review Request: keysmith - OTP client for Plasma Mobile and Desktop Product: Fedora Version: rawhide Hardware: All OS: Linux Status: NEW Component: Package Review Severity: medium Assignee: nobody(a)fedoraproject.org Reporter: thunderbirdtr(a)fedoraproject.org QA Contact: extras-qa(a)fedoraproject.org CC: package-review(a)lists.fedoraproject.org Target Milestone: --- Classification: Fedora Spec URL: https://pagure.io/plasma-mobile-apps/blob/master/f/keysmith/keysmith.spec SRPM URL: https://pagure.io/plasma-mobile-apps/blob/master/f/keysmith/keysmith-21.05-… Description: OTP client for Plasma Mobile and Desktop Fedora Account System Username: thunderbirdtr -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

1 2

[Bug 1959785] New: Review Request: applet-window-buttons - Plasma 5 applet to show window buttons in panels
by bugzilla＠redhat.com 17 May '21

17 May '21

https://bugzilla.redhat.com/show_bug.cgi?id=1959785 Bug ID: 1959785 Summary: Review Request: applet-window-buttons - Plasma 5 applet to show window buttons in panels Product: Fedora Version: rawhide Hardware: All OS: Linux Status: NEW Component: Package Review Severity: medium Assignee: nobody(a)fedoraproject.org Reporter: thunderbirdtr(a)fedoraproject.org QA Contact: extras-qa(a)fedoraproject.org CC: package-review(a)lists.fedoraproject.org Target Milestone: --- Classification: Fedora Spec URL: https://pagure.io/Maukit-Packages/blob/main/f/applet-window-buttons/applet-… SRPM URL: https://pagure.io/Maukit-Packages/blob/main/f/applet-window-buttons/applet-… Copr Repo : https://copr.fedorainfracloud.org/coprs/thunderbirdtr/MauiKit-packages/ Last copr build result : https://copr.fedorainfracloud.org/coprs/thunderbirdtr/MauiKit-packages/buil… Description: Plasma 5 applet to show window buttons in panels Fedora Account System Username: thunderbirdtr Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - If your application is a C or C++ application you must list a BuildRequires against gcc, gcc-c++ or clang. Note: No gcc, gcc-c++ or clang found in BuildRequires See: https://docs.fedoraproject.org/en-US/packaging-guidelines/C_and_C++/ - Package installs a %{name}.desktop using desktop-file-install or desktop- file-validate if there is such a file. ===== MUST items ===== C/C++: [ ]: Package does not contain kernel modules. [ ]: Package contains no static executables. [ ]: Development (unversioned) .so files in -devel subpackage, if present. Note: Unversioned so-files in private %_libdir subdirectory (see attachment). Verify they are not in ld path. [x]: Header files in -devel subpackage, if present. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. Generic: [ ]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. Note: Using prebuilt packages [ ]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [ ]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "GNU General Public License, Version 2", "GNU Lesser General Public License, Version 2.1", "GNU General Public License v2.0 or later". 11 files have unknown license. Detailed output of licensecheck in /var/lib/copr-rpmbuild/results/applet- window-buttons/licensecheck.txt [ ]: License file installed when any subpackage combination is installed. [ ]: %build honors applicable compiler flags or justifies otherwise. [ ]: Package contains no bundled libraries without FPC exception. [ ]: Changelog in prescribed format. [ ]: Sources contain only permissible code or content. [ ]: Development files must be in a -devel package [ ]: Package uses nothing in %doc for runtime. [ ]: Package consistently uses macros (instead of hard-coded directory names). [ ]: Package is named according to the Package Naming Guidelines. [ ]: Package does not generate any conflict. [ ]: Package obeys FHS, except libexecdir and /usr/target. [ ]: If the package is a rename of another package, proper Obsoletes and Provides are present. [ ]: Requires correct, justified where necessary. [ ]: Spec file is legible and written in American English. [ ]: Package contains systemd file(s) if in need. [ ]: Useful -debuginfo package or justification otherwise. [ ]: Package is not known to require an ExcludeArch tag. [ ]: Package complies to the Packaging Guidelines [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package contains desktop file if it is a GUI application. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 0 bytes in 0 files. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [!]: Reviewer should test that the package builds in mock. [ ]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [ ]: Final provides and requires are sane (see attachments). [ ]: Package functions as described. [ ]: Latest version is packaged. [ ]: Package does not include license text files separate from upstream. [ ]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [ ]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [ ]: Package should compile and build into binary rpms on all supported architectures. [ ]: %check is present and all tests pass. [ ]: Packages should try to preserve timestamps of original installed files. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Fully versioned dependency in subpackages if applicable. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on debuginfo package(s). Note: No rpmlint messages. [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. Rpmlint ------- Checking: applet-window-buttons-0.9.0-1.fc35.x86_64.rpm applet-window-buttons-debuginfo-0.9.0-1.fc35.x86_64.rpm applet-window-buttons-debugsource-0.9.0-1.fc35.x86_64.rpm applet-window-buttons-0.9.0-1.fc35.src.rpm applet-window-buttons.x86_64: W: spelling-error %description -l en_US appmenu -> app menu, app-menu, appeasement applet-window-buttons.x86_64: W: spelling-error %description -l en_US plasmoid -> plasma applet-window-buttons.x86_64: W: no-documentation applet-window-buttons.src: W: spelling-error %description -l en_US appmenu -> app menu, app-menu, appeasement applet-window-buttons.src: W: spelling-error %description -l en_US plasmoid -> plasma 4 packages and 0 specfiles checked; 0 errors, 5 warnings. Rpmlint (debuginfo) ------------------- Checking: applet-window-buttons-debuginfo-0.9.0-1.fc35.x86_64.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. Rpmlint (installed packages) ---------------------------- applet-window-buttons.x86_64: W: spelling-error %description -l en_US appmenu -> app menu, app-menu, appeasement applet-window-buttons.x86_64: W: spelling-error %description -l en_US plasmoid -> plasma applet-window-buttons.x86_64: W: no-documentation 3 packages and 0 specfiles checked; 0 errors, 3 warnings. Unversioned so-files -------------------- applet-window-buttons: /usr/lib64/qt5/qml/org/kde/appletdecoration/libappletdecorationplugin.so Source checksums ---------------- https://github.com/psifidotos/applet-window-buttons/archive/0.9.0/applet-wi… : CHECKSUM(SHA256) this package : 053201441e2cc7c0589c920028b985752ad9a87dc0f7fb35070cf44c9fcfbab7 CHECKSUM(SHA256) upstream package : 053201441e2cc7c0589c920028b985752ad9a87dc0f7fb35070cf44c9fcfbab7 Requires -------- applet-window-buttons (rpmlib, GLIBC filtered): libKF5ConfigCore.so.5()(64bit) libKF5ConfigWidgets.so.5()(64bit) libKF5CoreAddons.so.5()(64bit) libKF5I18n.so.5()(64bit) libKF5Plasma.so.5()(64bit) libKF5Service.so.5()(64bit) libQt5Core.so.5()(64bit) libQt5Core.so.5(Qt_5)(64bit) libQt5Core.so.5(Qt_5.15)(64bit) libQt5DBus.so.5()(64bit) libQt5DBus.so.5(Qt_5)(64bit) libQt5Gui.so.5()(64bit) libQt5Gui.so.5(Qt_5)(64bit) libQt5Qml.so.5()(64bit) libQt5Qml.so.5(Qt_5)(64bit) libQt5Quick.so.5()(64bit) libQt5Quick.so.5(Qt_5)(64bit) libQt5Widgets.so.5()(64bit) libQt5Widgets.so.5(Qt_5)(64bit) libc.so.6()(64bit) libkdecorations2.so.5()(64bit) libkdecorations2private.so.8()(64bit) libstdc++.so.6()(64bit) libstdc++.so.6(CXXABI_1.3)(64bit) libstdc++.so.6(CXXABI_1.3.9)(64bit) rtld(GNU_HASH) applet-window-buttons-debuginfo (rpmlib, GLIBC filtered): applet-window-buttons-debugsource (rpmlib, GLIBC filtered): Provides -------- applet-window-buttons: applet-window-buttons applet-window-buttons(x86-64) libappletdecorationplugin.so()(64bit) metainfo() metainfo(org.kde.windowbuttons.appdata.xml) applet-window-buttons-debuginfo: applet-window-buttons-debuginfo applet-window-buttons-debuginfo(x86-64) debuginfo(build-id) libappletdecorationplugin.so-0.9.0-1.fc35.x86_64.debug()(64bit) applet-window-buttons-debugsource: applet-window-buttons-debugsource applet-window-buttons-debugsource(x86-64) -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

1 3

[Bug 1954842] New: Review Request: sndfile-tools - Programs to do interesting things with sound files
by bugzilla＠redhat.com 17 May '21

17 May '21

https://bugzilla.redhat.com/show_bug.cgi?id=1954842 Bug ID: 1954842 Summary: Review Request: sndfile-tools - Programs to do interesting things with sound files Product: Fedora Version: rawhide Hardware: All OS: Linux Status: NEW Component: Package Review Severity: medium Priority: medium Assignee: nobody(a)fedoraproject.org Reporter: guido.aulisi(a)gmail.com QA Contact: extras-qa(a)fedoraproject.org CC: package-review(a)lists.fedoraproject.org Target Milestone: --- Classification: Fedora Spec URL: https://fedorapeople.org/~tartina/sndfile-tools.spec SRPM URL: https://fedorapeople.org/~tartina/sndfile-tools-1.5-1.fc35.src.rpm Description: Sndfile-tools is a small collection of programs that use libsndfile and other libraries to do useful things. Included tools are: sndfile-generate-chirp sndfile-jackplay sndfile-mix-to-mono sndfile-resample sndfile-spectrogram sndfile-waveform Fedora Account System Username: tartina Link to successful scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=66881824 sndfile-resample has been recently moved from libsamplerate to this package, the new libsamplerate package is already present in rawhide -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

1 8

[Bug 1957816] New: Review Request: kweather - Convergent KDE weather application
by bugzilla＠redhat.com 17 May '21

17 May '21

https://bugzilla.redhat.com/show_bug.cgi?id=1957816 Bug ID: 1957816 Summary: Review Request: kweather - Convergent KDE weather application Product: Fedora Version: rawhide Hardware: All OS: Linux Status: NEW Component: Package Review Severity: medium Assignee: nobody(a)fedoraproject.org Reporter: thunderbirdtr(a)fedoraproject.org QA Contact: extras-qa(a)fedoraproject.org CC: package-review(a)lists.fedoraproject.org Target Milestone: --- Classification: Fedora Spec URL: https://pagure.io/kweather/blob/main/f/kweather.spec SRPM URL: https://pagure.io/kweather/blob/main/f/kweather-0.4-1.fc34.src.rpm Copr URL : https://copr.fedorainfracloud.org/coprs/thunderbirdtr/kweather/ Copr Build URL : https://copr.fedorainfracloud.org/coprs/thunderbirdtr/kweather/build/216788… Description: Convergent KDE weather application Fedora Account System Username: thunderbirdtr Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed ===== MUST items ===== C/C++: [ ]: Package does not contain kernel modules. [ ]: Package contains no static executables. [x]: If your application is a C or C++ application you must list a BuildRequires against gcc, gcc-c++ or clang. [x]: Header files in -devel subpackage, if present. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. Generic: [ ]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. Note: Using prebuilt packages [ ]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [ ]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "Creative Commons Attribution 4.0 International License", "GNU General Public License, Version 2". 104 files have unknown license. Detailed output of licensecheck in /var/lib/copr-rpmbuild/results/kweather/licensecheck.txt [ ]: License file installed when any subpackage combination is installed. [ ]: Package must own all directories that it creates. Note: Directories without known owners: /usr/share/icons/hicolor/scalable, /usr/share/icons/hicolor/scalable/apps, /usr/share/icons/hicolor, /usr/share/dbus-1/services, /usr/share/dbus-1 [ ]: %build honors applicable compiler flags or justifies otherwise. [ ]: Package contains no bundled libraries without FPC exception. [ ]: Changelog in prescribed format. [ ]: Sources contain only permissible code or content. [ ]: Development files must be in a -devel package [ ]: Package uses nothing in %doc for runtime. [ ]: Package consistently uses macros (instead of hard-coded directory names). [ ]: Package is named according to the Package Naming Guidelines. [ ]: Package does not generate any conflict. [ ]: Package obeys FHS, except libexecdir and /usr/target. [ ]: If the package is a rename of another package, proper Obsoletes and Provides are present. [ ]: Requires correct, justified where necessary. [ ]: Spec file is legible and written in American English. [ ]: Package contains systemd file(s) if in need. [ ]: Useful -debuginfo package or justification otherwise. [ ]: Package is not known to require an ExcludeArch tag. [ ]: Package complies to the Packaging Guidelines [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package contains desktop file if it is a GUI application. [x]: Package installs a %{name}.desktop using desktop-file-install or desktop-file-validate if there is such a file. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 0 bytes in 0 files. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [!]: Reviewer should test that the package builds in mock. [ ]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [ ]: Final provides and requires are sane (see attachments). [ ]: Package functions as described. [ ]: Latest version is packaged. [ ]: Package does not include license text files separate from upstream. [ ]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [ ]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [ ]: Package should compile and build into binary rpms on all supported architectures. [ ]: %check is present and all tests pass. [ ]: Packages should try to preserve timestamps of original installed files. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Fully versioned dependency in subpackages if applicable. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on debuginfo package(s). Note: There are rpmlint messages (see attachment). [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. Rpmlint ------- Checking: kweather-0.4-1.fc35.x86_64.rpm kweather-debuginfo-0.4-1.fc35.x86_64.rpm kweather-debugsource-0.4-1.fc35.x86_64.rpm kweather-0.4-1.fc35.src.rpm kweather.x86_64: W: incoherent-version-in-changelog 0.1.1-1 ['0.4-1.fc35', '0.4-1'] kweather.x86_64: W: invalid-license GPL-2.0+ kweather.x86_64: W: no-documentation kweather.x86_64: W: no-manual-page-for-binary kweather kweather.x86_64: E: invalid-desktopfile /usr/share/applications/org.kde.kweather.desktop value "0.3" for key "Version" in group "Desktop Entry" is not a known version kweather-debuginfo.x86_64: W: invalid-license GPL-2.0+ kweather-debugsource.x86_64: W: invalid-license GPL-2.0+ kweather.src: W: invalid-license GPL-2.0+ kweather.src:54: W: macro-in-comment %{buildroot} kweather.src:54: W: macro-in-comment %{_datadir} kweather.src:54: W: macro-in-comment %{name} kweather.src:58: W: macro-in-comment %{buildroot} kweather.src:58: W: macro-in-comment %{_datadir} kweather.src:58: W: macro-in-comment %{name} 4 packages and 0 specfiles checked; 1 errors, 13 warnings. Rpmlint (debuginfo) ------------------- Checking: kweather-debuginfo-0.4-1.fc35.x86_64.rpm kweather-debuginfo.x86_64: W: invalid-license GPL-2.0+ 1 packages and 0 specfiles checked; 0 errors, 1 warnings. Rpmlint (installed packages) ---------------------------- kweather-debuginfo.x86_64: W: invalid-license GPL-2.0+ kweather-debugsource.x86_64: W: invalid-license GPL-2.0+ kweather.x86_64: W: incoherent-version-in-changelog 0.1.1-1 ['0.4-1.fc35', '0.4-1'] kweather.x86_64: W: invalid-license GPL-2.0+ kweather.x86_64: W: no-documentation kweather.x86_64: W: no-manual-page-for-binary kweather kweather.x86_64: E: invalid-desktopfile /usr/share/applications/org.kde.kweather.desktop value "0.3" for key "Version" in group "Desktop Entry" is not a known version 3 packages and 0 specfiles checked; 1 errors, 6 warnings. Source checksums ---------------- https://invent.kde.org/plasma-mobile/kweather/-/archive/0.4/kweather-0.4.ta… : CHECKSUM(SHA256) this package : 94db92197a871d32a64117a4639e905f874f65f64e8975bf92c32f3fd31c70bd CHECKSUM(SHA256) upstream package : 94db92197a871d32a64117a4639e905f874f65f64e8975bf92c32f3fd31c70bd Requires -------- kweather (rpmlib, GLIBC filtered): kf5-kirigami2 libKF5ConfigCore.so.5()(64bit) libKF5ConfigGui.so.5()(64bit) libKF5CoreAddons.so.5()(64bit) libKF5I18n.so.5()(64bit) libQt5Core.so.5()(64bit) libQt5Core.so.5(Qt_5)(64bit) libQt5Core.so.5(Qt_5.15)(64bit) libQt5Network.so.5()(64bit) libQt5Network.so.5(Qt_5)(64bit) libQt5Qml.so.5()(64bit) libQt5Qml.so.5(Qt_5)(64bit) libQt5Widgets.so.5()(64bit) libQt5Widgets.so.5(Qt_5)(64bit) libc.so.6()(64bit) libstdc++.so.6()(64bit) libstdc++.so.6(CXXABI_1.3)(64bit) rtld(GNU_HASH) kweather-debuginfo (rpmlib, GLIBC filtered): kweather-debugsource (rpmlib, GLIBC filtered): Provides -------- kweather: application() application(org.kde.kweather.desktop) kweather kweather(x86-64) metainfo() metainfo(org.kde.kweather.appdata.xml) kweather-debuginfo: debuginfo(build-id) kweather-debuginfo kweather-debuginfo(x86-64) kweather-debugsource: kweather-debugsource kweather-debugsource(x86-64) Generated by fedora-review 0.7.6 (b083f91) last change: 2020-11-10 Command line :/usr/bin/fedora-review --no-colors --prebuilt --rpm-spec --name kweather --mock-config /var/lib/copr-rpmbuild/results/configs/child.cfg Buildroot used: fedora-rawhide-x86_64 Active plugins: C/C++, Generic, Shell-api Disabled plugins: Haskell, Ocaml, Perl, R, Java, PHP, fonts, Python, SugarActivity Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

1 10

[Bug 1957702] New: Review Request: kweathercore - Library to facilitate retrieval of weather information
by bugzilla＠redhat.com 17 May '21

17 May '21

https://bugzilla.redhat.com/show_bug.cgi?id=1957702 Bug ID: 1957702 Summary: Review Request: kweathercore - Library to facilitate retrieval of weather information Product: Fedora Version: rawhide Hardware: All OS: Linux Status: NEW Component: Package Review Severity: medium Assignee: nobody(a)fedoraproject.org Reporter: thunderbirdtr(a)fedoraproject.org QA Contact: extras-qa(a)fedoraproject.org CC: package-review(a)lists.fedoraproject.org Target Milestone: --- Classification: Fedora Spec URL: https://pagure.io/kweathercore/blob/main/f/kweathercore.spec SRPM URL: https://pagure.io/kweathercore/blob/main/f/kweathercore-0.1.1-1.fc34.src.rpm Description: kweathercore - Library to facilitate retrieval of weather information Fedora Account System Username: thunderbirdtr Copr repo : https://copr.fedorainfracloud.org/coprs/thunderbirdtr/kweather/ Package review enabled : https://copr.fedorainfracloud.org/coprs/thunderbirdtr/kweather/build/216785… Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - Development (unversioned) .so files in -devel subpackage, if present. Note: Unversioned so-files directly in %_libdir. See: https://docs.fedoraproject.org/en-US/packaging- guidelines/#_devel_packages ===== MUST items ===== C/C++: [ ]: Package does not contain kernel modules. [ ]: Package contains no static executables. [x]: If your application is a C or C++ application you must list a BuildRequires against gcc, gcc-c++ or clang. [x]: Header files in -devel subpackage, if present. [x]: ldconfig not called in %post and %postun for Fedora 28 and later. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. Generic: [ ]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. Note: Using prebuilt packages [ ]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [ ]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "GNU Library General Public License, Version 2.0". 49 files have unknown license. Detailed output of licensecheck in /var/lib/copr- rpmbuild/results/kweathercore/licensecheck.txt [ ]: License file installed when any subpackage combination is installed. [ ]: Package must own all directories that it creates. Note: Directories without known owners: /usr/include/KF5, /usr/lib64/qt5/mkspecs/modules, /usr/share/doc/qt5, /usr/lib64/qt5/mkspecs, /usr/lib64/qt5 [ ]: %build honors applicable compiler flags or justifies otherwise. [ ]: Package contains no bundled libraries without FPC exception. [ ]: Changelog in prescribed format. [ ]: Sources contain only permissible code or content. [ ]: Package contains desktop file if it is a GUI application. [ ]: Development files must be in a -devel package [ ]: Package uses nothing in %doc for runtime. [ ]: Package consistently uses macros (instead of hard-coded directory names). [ ]: Package is named according to the Package Naming Guidelines. [ ]: Package does not generate any conflict. [ ]: Package obeys FHS, except libexecdir and /usr/target. [ ]: If the package is a rename of another package, proper Obsoletes and Provides are present. [ ]: Requires correct, justified where necessary. [ ]: Spec file is legible and written in American English. [ ]: Package contains systemd file(s) if in need. [ ]: Useful -debuginfo package or justification otherwise. [ ]: Package is not known to require an ExcludeArch tag. [ ]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 368640 bytes in 3 files. [ ]: Package complies to the Packaging Guidelines [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [!]: Reviewer should test that the package builds in mock. [ ]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [ ]: Final provides and requires are sane (see attachments). [ ]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in kweathercore-docs [ ]: Package functions as described. [ ]: Latest version is packaged. [ ]: Package does not include license text files separate from upstream. [ ]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [ ]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [ ]: Package should compile and build into binary rpms on all supported architectures. [ ]: %check is present and all tests pass. [ ]: Packages should try to preserve timestamps of original installed files. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on debuginfo package(s). Note: No rpmlint messages. [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. Rpmlint ------- Checking: kweathercore-0.1.1-1.fc35.x86_64.rpm kweathercore-devel-0.1.1-1.fc35.x86_64.rpm kweathercore-docs-0.1.1-1.fc35.noarch.rpm kweathercore-debuginfo-0.1.1-1.fc35.x86_64.rpm kweathercore-debugsource-0.1.1-1.fc35.x86_64.rpm kweathercore-0.1.1-1.fc35.src.rpm kweathercore.x86_64: W: spelling-error %description -l en_US moonrise -> moon rise, moon-rise, moonshiner kweathercore.x86_64: W: spelling-error %description -l en_US informations -> information, information's, in formations kweathercore.x86_64: W: no-documentation kweathercore.x86_64: W: devel-file-in-non-devel-package /usr/lib64/libKF5KWeatherCore.so kweathercore-devel.x86_64: W: no-documentation kweathercore.src: W: spelling-error %description -l en_US moonrise -> moon rise, moon-rise, moonshiner kweathercore.src: W: spelling-error %description -l en_US informations -> information, information's, in formations 6 packages and 0 specfiles checked; 0 errors, 7 warnings. Rpmlint (debuginfo) ------------------- Checking: kweathercore-debuginfo-0.1.1-1.fc35.x86_64.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. Rpmlint (installed packages) ---------------------------- kweathercore.x86_64: W: spelling-error %description -l en_US moonrise -> moon rise, moon-rise, moonshiner kweathercore.x86_64: W: spelling-error %description -l en_US informations -> information, information's, in formations kweathercore.x86_64: W: no-documentation kweathercore.x86_64: W: devel-file-in-non-devel-package /usr/lib64/libKF5KWeatherCore.so kweathercore-devel.x86_64: W: no-documentation 5 packages and 0 specfiles checked; 0 errors, 5 warnings. Unversioned so-files -------------------- kweathercore: /usr/lib64/libKF5KWeatherCore.so Source checksums ---------------- https://invent.kde.org/libraries/kweathercore/-/archive/release-0.1.1/kweat… : CHECKSUM(SHA256) this package : e199bbb159ef8175aed29daa7a13c3e72cc84549eaebfa59118f6c4685ee6421 CHECKSUM(SHA256) upstream package : e199bbb159ef8175aed29daa7a13c3e72cc84549eaebfa59118f6c4685ee6421 Requires -------- kweathercore (rpmlib, GLIBC filtered): libKF5I18n.so.5()(64bit) libKF5KWeatherCore.so.5()(64bit) libQt5Core.so.5()(64bit) libQt5Core.so.5(Qt_5)(64bit) libQt5Core.so.5(Qt_5.15)(64bit) libQt5Network.so.5()(64bit) libQt5Network.so.5(Qt_5)(64bit) libQt5Positioning.so.5()(64bit) libQt5Positioning.so.5(Qt_5)(64bit) libc.so.6()(64bit) libstdc++.so.6()(64bit) libstdc++.so.6(CXXABI_1.3)(64bit) rtld(GNU_HASH) kweathercore-devel (rpmlib, GLIBC filtered): cmake-filesystem(x86-64) kweathercore(x86-64) libKF5KWeatherCore.so.5()(64bit) kweathercore-docs (rpmlib, GLIBC filtered): kweathercore-debuginfo (rpmlib, GLIBC filtered): kweathercore-debugsource (rpmlib, GLIBC filtered): Provides -------- kweathercore: kweathercore kweathercore(x86-64) libKF5KWeatherCore.so.5()(64bit) kweathercore-devel: cmake(KF5KWeatherCore) cmake(kf5kweathercore) kweathercore-devel kweathercore-devel(x86-64) kweathercore-docs: kweathercore-docs kweathercore-debuginfo: debuginfo(build-id) kweathercore-debuginfo kweathercore-debuginfo(x86-64) libKF5KWeatherCore.so.0.1.1-0.1.1-1.fc35.x86_64.debug()(64bit) kweathercore-debugsource: kweathercore-debugsource kweathercore-debugsource(x86-64) Generated by fedora-review 0.7.6 (b083f91) last change: 2020-11-10 Command line :/usr/bin/fedora-review --no-colors --prebuilt --rpm-spec --name kweathercore --mock-config /var/lib/copr-rpmbuild/results/configs/child.cfg Buildroot used: fedora-rawhide-x86_64 Active plugins: Shell-api, C/C++, Generic Disabled plugins: Perl, Haskell, Python, Java, Ocaml, fonts, PHP, R, SugarActivity Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

1 5

[Bug 587978] Review Request: whatweb - Web scanner to identify what websites are running
by bugzilla＠redhat.com 16 May '21

16 May '21

https://bugzilla.redhat.com/show_bug.cgi?id=587978 Otto Urpelainen <oturpe(a)iki.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|needinfo?(oturpe(a)iki.fi) |needinfo?(rebus(a)seznam.cz) --- Comment #34 from Otto Urpelainen <oturpe(a)iki.fi> --- Commenting only on items where I have something to all, for all others: Thank you for the explanation. (In reply to Michal Ambroz from comment #32) > (In reply to Otto Urpelainen from comment #31) > > > 3. Fixing env shebangs should not be required in Fedora anymore. If this is > > still needed for some reason (RHEL perhaps?), comment should be updated to match > > https://docs.fedoraproject.org/en-US/packaging-guidelines/Ruby/#_shebang_li… > > I consider env to be potential security problem and preffer to be explicit > about the interpreter used in the packaged stuff. > The guide is saying as well that it SHOULD use #!/usr/bin/ruby . > The "env ruby" is not always only /usr/bin/ruby. Depending on environment > settings it could be also /usr/local/bin/ruby or ~user/bin/ruby or even > /tmp/you_have_been_hacked/ruby . Ah, I apologize, I worded by comment badly and linked to wrong, only marginally relevant section of the guidelines. What I was trying to say was this: Nowadays, shebang lines are automatically modified to replace env with the correct interpreter, so there should be no need to do that manually. Reference: https://docs.fedoraproject.org/en-US/packaging-guidelines/#_shebang_lines Doing that manually is not forbidden either, so it can stay that way if you prefer. But doing that explicitly does not change the result from what the defaults already do. > > 4. I do not understand this. Is this an issue with upstream man pages? If > > so, a fix or an issue should be submitted and referenced from the specfile. > > > > > # Unknown macros in manpage > > > sed -i -e 's|^.ni||; s|^\./plugins-disabled|+\./plugins-disabled|' whatweb.1 > Yes ... I guess that on Ubuntu they use different groff for formatting the > man pages so it is ok for them. > On Fedora it complains so I have to remove that tags. I see, it may be for the '.ni' case. The './plugins-disabled' is for sure part of the example for enabling and disabling plugin directories. I took a closer look at the upstream whatweb.1, and my interpretation is that the file simply is in a bad shape and would benefit from a PR like this. I encourage submitting fixes. But if you do not want to do that, that's ok too, I won't reject this review for that. Regarding the substitutions: 1. Instead of 's|^.ni||', use 's|^\.ni||', to replace the unknown request '.ni' and not lines starting with 'Ani', 'Bni' etc. 2. Instead of 's|^\./plugins-disabled|+\./plugins-disabled|', use 's|^\./plugins-disabled|\\\./plugins-disabled|'. '+' is not a Groff way to escape '.', but happens to be Whatweb syntax and thus changes the example. -- You are receiving this mail because: You are always notified about changes to this product and component

1 0

[Bug 587978] Review Request: whatweb - Web scanner to identify what websites are running
by bugzilla＠redhat.com 16 May '21

16 May '21

https://bugzilla.redhat.com/show_bug.cgi?id=587978 --- Comment #33 from Mamoru TASAKA <mtasaka(a)fedoraproject.org> --- (In reply to Otto Urpelainen from comment #31) > 3. Fixing env shebangs should not be required in Fedora anymore. If this is > still needed for some reason (RHEL perhaps?), comment should be updated to > match > > > # Fedora using Rubypick > > sed -i -e 's|#!/usr/bin/env ruby|#!/usr/bin/ruby|; s|#!/bin/env ruby|#!/usr/bin/ruby|;' \ > whatweb plugin-development/find-common-stuff > plugin-development/get-pattern > > Reference: > https://docs.fedoraproject.org/en-US/packaging-guidelines/Ruby/ > #_shebang_lines > This does not say using env on shabang is permitted. The above guideline says when the package really needs jruby, you can write "#!/usr/bin/jruby" on shebang (but I don't think jruby on Fedora is well-maintained). All other should use "#!/usr/bin/ruby" on shebang. Anyway env should not be used on shebang. -- You are receiving this mail because: You are always notified about changes to this product and component

1 0

[Bug 1956051] New: Review Request: R-vcd - Visualizing categorical data
by bugzilla＠redhat.com 16 May '21

16 May '21

https://bugzilla.redhat.com/show_bug.cgi?id=1956051 Bug ID: 1956051 Summary: Review Request: R-vcd - Visualizing categorical data Product: Fedora Version: rawhide Hardware: All OS: Linux Status: NEW Component: Package Review Severity: medium Priority: medium Assignee: nobody(a)fedoraproject.org Reporter: iztok(a)iztok-jr-fister.eu QA Contact: extras-qa(a)fedoraproject.org CC: package-review(a)lists.fedoraproject.org Target Milestone: --- Classification: Fedora Spec URL: https://raw.githubusercontent.com/firefly-cpp/rpm-vcd/main/R-vcd.spec SRPM URL: https://github.com/firefly-cpp/rpm-vcd/raw/main/R-vcd-1.4.8-1.fc33.src.rpm Description: Visualization techniques, data sets, summary and inference procedures aimed particularly at categorical data. Special emphasis is given to highly extensible grid graphics. The package was package was originally inspired by the book "Visualizing Categorical Data" by Michael Friendly and is now the main support package for a new book, "Discrete Data Analysis with R" by Michael Friendly and David Meyer (2015). Fedora Account System Username: iztokf -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

1 13

[Bug 1960877] New: Review Request: golang-github-facebookgo-clock - Clock is a small library for mocking time in Go
by bugzilla＠redhat.com 15 May '21

15 May '21

https://bugzilla.redhat.com/show_bug.cgi?id=1960877 Bug ID: 1960877 Summary: Review Request: golang-github-facebookgo-clock - Clock is a small library for mocking time in Go Product: Fedora Version: rawhide Hardware: All OS: Linux Status: NEW Component: Package Review Severity: medium Priority: medium Assignee: nobody(a)fedoraproject.org Reporter: bperkins(a)redhat.com QA Contact: extras-qa(a)fedoraproject.org CC: package-review(a)lists.fedoraproject.org Target Milestone: --- Classification: Fedora Spec URL: https://raw.githubusercontent.com/bdperkin/haproxytech/master/SPECS/golang-… SRPM URL: https://download.copr.fedorainfracloud.org/results/bdperkin/haproxytech/fed… Description: Clock is a small library for mocking time in Go. Fedora Account System Username: bdperkin -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

1 2

← Newer
1
...
61
62
63
64
65
66
67
...
71
Older →

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

package-review May 2021