https://bugzilla.redhat.com/show_bug.cgi?id=2183721
Bug ID: 2183721
Summary: Review Request: nvi - use alternative source because
kotnet.org disappeared (unretire request)
Product: Fedora
Version: rawhide
Hardware: All
OS: Linux
Status: NEW
Component: Package Review
Severity: medium
Assignee: nobody(a)fedoraproject.org
Reporter: dongdigua(a)outlook.com
QA Contact: extras-qa(a)fedoraproject.org
CC: package-review(a)lists.fedoraproject.org
Target Milestone: ---
Classification: Fedora
Spec URL: http://hws.shenjack.top:5504/file/sloth-wolf-mole/nvi.spec
SRPM URL:
http://hws.shenjack.top:5504/file/seal-rabbit/nvi-1.81.6-24.fc38.src.rpm
Description:
It is orphaned and retired for "Failed to build from source".
Actually it is because unable to fetch source from
http://www.kotnet.org/~skimo/nvi
since kotnet.org is a student orgnization and seems disappeared in 2014.
But we can get alternative source from https://repo.or.cz/nvi.git or
Debian(NixOS gets it from there) or slackware etc.
And also replace /usr/lib/rpm/config.{guess,sub} with
/usr/lib/rpm/redhat/config.{guess,sub}
Fedora Account System Username: dongdigua
--
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2183721
https://bugzilla.redhat.com/show_bug.cgi?id=2191685
Bug ID: 2191685
Summary: Review Request: ncurses-epel - Ncurses support
utilities
Product: Fedora
Version: rawhide
Status: NEW
Component: Package Review
Assignee: nobody(a)fedoraproject.org
Reporter: michel(a)michel-slm.name
QA Contact: extras-qa(a)fedoraproject.org
CC: package-review(a)lists.fedoraproject.org
Target Milestone: ---
Classification: Fedora
Spec URL: https://salimma.fedorapeople.org/ncurses-epel.spec
SRPM URL:
https://salimma.fedorapeople.org/ncurses-epel-6.2-8.20210508.1.el9.src.rpm
Description:
The curses library routines are a terminal-independent method of
updating character screens with reasonable optimization. The ncurses
(new curses) library is a freely distributable replacement for the
discontinued 4.4 BSD classic curses library.
This package contains support utilities, including a terminfo compiler
tic, a decompiler infocmp, clear, tput, tset, and a termcap conversion
tool captoinfo.
Fedora Account System Username: salimma
--
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2191685
https://bugzilla.redhat.com/show_bug.cgi?id=2188412
Bug ID: 2188412
Summary: Review Request: <main package name here> - <short
summary here>
Product: Fedora
Version: rawhide
Hardware: All
OS: Linux
Status: NEW
Component: Package Review
Severity: medium
Priority: medium
Assignee: nobody(a)fedoraproject.org
Reporter: kvanderr(a)redhat.com
QA Contact: extras-qa(a)fedoraproject.org
CC: package-review(a)lists.fedoraproject.org
Target Milestone: ---
Classification: Fedora
Copr URL: https://copr.fedorainfracloud.org/coprs/kpvdr/opentelemetry-cpp/
Spec URL:
https://download.copr.fedorainfracloud.org/results/kpvdr/opentelemetry-cpp/…
SRPM URL:
https://download.copr.fedorainfracloud.org/results/kpvdr/opentelemetry-cpp/…
Description: Opentelemetry C++ provides a C++ opentelemetry client alongside
other clients already available or being reviewed in Fedora. Upstream project:
https://github.com/open-telemetry/opentelemetry-cpp, the c++ client of
Opentelemetry (https://opentelemetry.io/). There is a patch which adds
SOVERSION and VERSION info to the cmake files so that the correct lib naming is
produced and a trivial addition to the version.h/cc files to avoid a rpmlint
warning. This package depends on nlohmann-json, also under review
(https://bugzilla.redhat.com/show_bug.cgi?id=2188395). This package is already
available in RHEL8 and RHEL9 as a dependency of an upcoming relese of AMQ
Clients (which contains qpid-proton). In Fedora, the current builds of
qpid-proton-0.38.0 do not have opentelemetry capability (the dependency is
optional), but once this and nlohmann-json become available, it will be rebuilt
with opentelemetry included.
Fedora Account System Username: kpvdr
===== MUST items =====
C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: If your application is a C or C++ application you must list a
BuildRequires against gcc, gcc-c++ or clang.
[x]: Header files in -devel subpackage, if present.
[x]: ldconfig not called in %post and %postun for Fedora 28 and later.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.
[x]: Development (unversioned) .so files in -devel subpackage, if present.
Generic:
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
Note: Using prebuilt packages
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses
found: "Unknown or generated", "Apache License 2.0", "*No copyright*
Apache License 2.0", "*No copyright* MIT License GNU General Public
License Apache License 2.0", "*No copyright* MIT License", "*No
copyright* Boost Software License 1.0", "MIT License". 128 files have
unknown license. Detailed output of licensecheck in /var/lib/copr-
rpmbuild/results/opentelemetry-cpp/licensecheck.txt
[-]: License file installed when any subpackage combination is installed.
No subpackages.
[?]: If the package is under multiple licenses, the licensing breakdown
must be documented in the spec.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[?]: Each %files section contains %defattr if rpm < 4.4
Note: %defattr present but not needed
[-]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present. Not a rename.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need. No systemd files.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 327680 bytes in 35 files. No large docs
[x]: Package complies to the Packaging Guidelines
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package must not depend on deprecated() packages.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
===== SHOULD items =====
Generic:
[x]: Reviewer should test that the package builds in mock.
[x]: If the source package does not include license text(s) as a separate
file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Package functions as described.
[x]: Latest version is packaged. 1.9.0
[x]: Package does not include license text files separate from upstream.
[!]: Patches link to upstream bugs/comments/lists or are otherwise
justified. See description, patch adds SOVERSION and VERSION info
to cmake files to satisfy Fedora lib naming
[?]: SourceX tarball generation or download is documented.
Note: Package contains tarball without URL, check comments
[?]: Sources are verified with gpgverify first in %prep if upstream
publishes signatures.
Note: gpgverify is not used.
[x]: Package should compile and build into binary rpms on all supported
architectures. See Copr
https://copr.fedorainfracloud.org/coprs/kpvdr/opentelemetry-cpp/
[x]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
files.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
$RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Fully versioned dependency in subpackages if applicable.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.
===== EXTRA items =====
Generic:
[x]: Rpmlint is run on debuginfo package(s).
Note: No rpmlint messages.
[x]: Rpmlint is run on all installed packages.
Note: There are rpmlint messages (see attachment).
[x]: Large data in /usr/share should live in a noarch subpackage if package
is arched.
Rpmlint
-------
Checking: opentelemetry-cpp-1.9.0-1.fc39.x86_64.rpm
opentelemetry-cpp-devel-1.9.0-1.fc39.x86_64.rpm
opentelemetry-cpp-debuginfo-1.9.0-1.fc39.x86_64.rpm
opentelemetry-cpp-debugsource-1.9.0-1.fc39.x86_64.rpm
opentelemetry-cpp-1.9.0-1.fc39.src.rpm
============================ rpmlint session starts
============================
rpmlint: 2.4.0
configuration:
/usr/lib/python3.11/site-packages/rpmlint/configdefaults.toml
/etc/xdg/rpmlint/fedora-legacy-licenses.toml
/etc/xdg/rpmlint/fedora-spdx-licenses.toml
/etc/xdg/rpmlint/fedora.toml
/etc/xdg/rpmlint/scoring.toml
/etc/xdg/rpmlint/users-groups.toml
/etc/xdg/rpmlint/warn-on-functions.toml
rpmlintrc: [PosixPath('/tmp/tmp9q1pw1jc')]
checks: 31, packages: 5
opentelemetry-cpp.spec: W: invalid-url Source0: opentelemetry-cpp-1.9.0.tar.gz
5 packages and 0 specfiles checked; 0 errors, 1 warnings, 0 badness; has taken
1.4 s
Rpmlint (debuginfo)
-------------------
Checking: opentelemetry-cpp-debuginfo-1.9.0-1.fc39.x86_64.rpm
============================ rpmlint session starts
============================
rpmlint: 2.4.0
configuration:
/usr/lib/python3.11/site-packages/rpmlint/configdefaults.toml
/etc/xdg/rpmlint/fedora-legacy-licenses.toml
/etc/xdg/rpmlint/fedora-spdx-licenses.toml
/etc/xdg/rpmlint/fedora.toml
/etc/xdg/rpmlint/scoring.toml
/etc/xdg/rpmlint/users-groups.toml
/etc/xdg/rpmlint/warn-on-functions.toml
rpmlintrc: [PosixPath('/tmp/tmp6trasyc5')]
checks: 31, packages: 1
1 packages and 0 specfiles checked; 0 errors, 0 warnings, 0 badness; has taken
0.6 s
Rpmlint (installed packages)
----------------------------
============================ rpmlint session starts
============================
rpmlint: 2.4.0
configuration:
/usr/lib/python3.11/site-packages/rpmlint/configdefaults.toml
/etc/xdg/rpmlint/fedora-legacy-licenses.toml
/etc/xdg/rpmlint/fedora-spdx-licenses.toml
/etc/xdg/rpmlint/fedora.toml
/etc/xdg/rpmlint/scoring.toml
/etc/xdg/rpmlint/users-groups.toml
/etc/xdg/rpmlint/warn-on-functions.toml
checks: 31, packages: 4
opentelemetry-cpp.x86_64: E: undefined-non-weak-symbol
/usr/lib64/libopentelemetry_exporter_ostream_metrics.so.1.9.0
_ZNK13opentelemetry2v13sdk8resource8Resource13GetAttributesEv
(/usr/lib64/libopentelemetry_exporter_ostream_metrics.so.1.9.0)
opentelemetry-cpp.x86_64: E: undefined-non-weak-symbol
/usr/lib64/libopentelemetry_http_client_curl.so.1.9.0
_ZN13opentelemetry2v13sdk6common12internal_log16GlobalLogHandler18GetHandlerAndLevelEv
(/usr/lib64/libopentelemetry_http_client_curl.so.1.9.0)
4 packages and 0 specfiles checked; 2 errors, 0 warnings, 2 badness; has taken
2.5 s
Requires
--------
opentelemetry-cpp (rpmlib, GLIBC filtered):
glibc
ld-linux-x86-64.so.2()(64bit)
libc.so.6()(64bit)
libcurl.so.4()(64bit)
libgcc_s.so.1()(64bit)
libgcc_s.so.1(GCC_3.0)(64bit)
libgcc_s.so.1(GCC_3.3.1)(64bit)
libm.so.6()(64bit)
libopentelemetry_common.so.1()(64bit)
libopentelemetry_http_client_curl.so.1()(64bit)
libopentelemetry_resources.so.1()(64bit)
libopentelemetry_trace.so.1()(64bit)
libstdc++.so.6()(64bit)
libstdc++.so.6(CXXABI_1.3)(64bit)
libstdc++.so.6(CXXABI_1.3.11)(64bit)
libstdc++.so.6(CXXABI_1.3.13)(64bit)
libstdc++.so.6(CXXABI_1.3.2)(64bit)
libstdc++.so.6(CXXABI_1.3.3)(64bit)
libstdc++.so.6(CXXABI_1.3.5)(64bit)
libstdc++.so.6(CXXABI_1.3.7)(64bit)
libthrift-0.14.0.so()(64bit)
rtld(GNU_HASH)
opentelemetry-cpp-devel (rpmlib, GLIBC filtered):
cmake-filesystem(x86-64)
libopentelemetry_common.so.1()(64bit)
libopentelemetry_exporter_in_memory.so.1()(64bit)
libopentelemetry_exporter_jaeger_trace.so.1()(64bit)
libopentelemetry_exporter_ostream_metrics.so.1()(64bit)
libopentelemetry_exporter_ostream_span.so.1()(64bit)
libopentelemetry_http_client_curl.so.1()(64bit)
libopentelemetry_metrics.so.1()(64bit)
libopentelemetry_resources.so.1()(64bit)
libopentelemetry_trace.so.1()(64bit)
libopentelemetry_version.so.1()(64bit)
opentelemetry-cpp(x86-64)
thrift
opentelemetry-cpp-debuginfo (rpmlib, GLIBC filtered):
opentelemetry-cpp-debugsource (rpmlib, GLIBC filtered):
Provides
--------
opentelemetry-cpp:
libopentelemetry_common.so.1()(64bit)
libopentelemetry_exporter_in_memory.so.1()(64bit)
libopentelemetry_exporter_jaeger_trace.so.1()(64bit)
libopentelemetry_exporter_ostream_metrics.so.1()(64bit)
libopentelemetry_exporter_ostream_span.so.1()(64bit)
libopentelemetry_http_client_curl.so.1()(64bit)
libopentelemetry_metrics.so.1()(64bit)
libopentelemetry_resources.so.1()(64bit)
libopentelemetry_trace.so.1()(64bit)
libopentelemetry_version.so.1()(64bit)
opentelemetry-cpp
opentelemetry-cpp(x86-64)
opentelemetry-cpp-devel:
cmake(opentelemetry-cpp)
opentelemetry-cpp-devel
opentelemetry-cpp-devel(x86-64)
opentelemetry-cpp-debuginfo:
debuginfo(build-id)
libopentelemetry_common.so.1.9.0-1.9.0-1.fc39.x86_64.debug()(64bit)
libopentelemetry_exporter_in_memory.so.1.9.0-1.9.0-1.fc39.x86_64.debug()(64bit)
libopentelemetry_exporter_jaeger_trace.so.1.9.0-1.9.0-1.fc39.x86_64.debug()(64bit)
libopentelemetry_exporter_ostream_metrics.so.1.9.0-1.9.0-1.fc39.x86_64.debug()(64bit)
libopentelemetry_exporter_ostream_span.so.1.9.0-1.9.0-1.fc39.x86_64.debug()(64bit)
libopentelemetry_http_client_curl.so.1.9.0-1.9.0-1.fc39.x86_64.debug()(64bit)
libopentelemetry_metrics.so.1.9.0-1.9.0-1.fc39.x86_64.debug()(64bit)
libopentelemetry_resources.so.1.9.0-1.9.0-1.fc39.x86_64.debug()(64bit)
libopentelemetry_trace.so.1.9.0-1.9.0-1.fc39.x86_64.debug()(64bit)
libopentelemetry_version.so.1.9.0-1.9.0-1.fc39.x86_64.debug()(64bit)
opentelemetry-cpp-debuginfo
opentelemetry-cpp-debuginfo(x86-64)
opentelemetry-cpp-debugsource:
opentelemetry-cpp-debugsource
opentelemetry-cpp-debugsource(x86-64)
Generated by fedora-review 0.9.0 (6761b6c) last change: 2022-08-23
Command line :/usr/bin/fedora-review --no-colors --prebuilt --rpm-spec --name
opentelemetry-cpp --mock-config
/var/lib/copr-rpmbuild/results/configs/child.cfg
Buildroot used: fedora-rawhide-x86_64
Active plugins: Generic, Shell-api, C/C++
Disabled plugins: R, Python, Haskell, SugarActivity, Perl, Ocaml, PHP, Java,
fonts
Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2188412
https://bugzilla.redhat.com/show_bug.cgi?id=2184722
Bug ID: 2184722
Summary: Review Request: rust-gdk4-wayland - Rust bindings of
the GDK 4 Wayland library
Product: Fedora
Version: rawhide
Hardware: All
OS: Linux
Status: NEW
Component: Package Review
Severity: medium
Priority: medium
Assignee: nobody(a)fedoraproject.org
Reporter: klember(a)redhat.com
QA Contact: extras-qa(a)fedoraproject.org
CC: package-review(a)lists.fedoraproject.org
Target Milestone: ---
Classification: Fedora
Spec URL: https://kalev.fedorapeople.org/rust-gdk4-wayland.spec
SRPM URL: https://kalev.fedorapeople.org/rust-gdk4-wayland-0.6.3-1.fc39.src.rpm
Description: Rust bindings of the GDK 4 Wayland library.
Fedora Account System Username: kalev
--
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2184722