https://bugzilla.redhat.com/show_bug.cgi?id=2161525
--- Comment #17 from Lumír Balhar lbalhar@redhat.com --- (In reply to Karolina Surma from comment #16)
I don't know whether this is required or just the oversensitivity of the fedora-review:
- If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. Note: License file third-party-licenses.json is not marked as %license See: https://docs.fedoraproject.org/en-US/packaging- guidelines/LicensingGuidelines/#_license_text
The file jupyterlab/static/third-party-licenses.json contains licenses for bundled packages and those are already mentioned in the License tag in the spec. Do you think that including an 1800-line-long JSON file with some of the licenses on a single line has any additional value?
[?]: Avoid bundling fonts in non-fonts packages. Note: Package contains font files
in jupyterlab/static:
$ ls | grep -v js 373c04fd2418f5c77eea.eot 3f6d3488cf65374f6f67.woff 79d088064beb3826054f.eot 8ea8791754915a898a31.woff2 9674eb1bd55047179038.svg 9834b82ad26e2a37583d.woff2 a3b9817780214caf01e8.svg af6397503fcefbd61397.ttf be0a084962d8066884f7.svg cb9e9e693192413cde2b.woff cda59d6efffa685830fd.ttf e4299464e7b012968eed.eot e42a88444448ac3d6054.woff2 e8711bbb871afd8e9dea.ttf f9217f66874b0c01cd8c.woff
Packaging guidelines are rather short on the matter and it's unclear to me what applies in this case. For example in the Web Assets page there's an explicit ban on WOFF font formats (https://docs.fedoraproject.org/en-US/packaging-guidelines/Web_Assets/). These files don't land in the %{_datadir}/web-assets though. I don't know what to suggest here :(.
The problem is that those font files are somehow built in a similar way as the other static files so I don't think it would be easy to just remove them, require a package containing the fonts and add a symlink somewhere. I did that in python-nbclassic, see https://src.fedoraproject.org/rpms/python-nbclassic/blob/rawhide/f/python-nb... But I have no idea how to do it here. I can remove the woff fonts and we'll see what happens.
Also, rpmlint prints out a long list of errors, some of them may be moot, but some look like something to fix.
python3-jupyterlab.noarch: E: zero-length /usr/lib/python3.11/site-packages/jupyterlab/themes/@jupyterlab/theme-dark- extension/index.js python3-jupyterlab.noarch: E: zero-length /usr/lib/python3.11/site-packages/jupyterlab/themes/@jupyterlab/theme-light- extension/index.js python3-jupyterlab.noarch: E: zero-length /usr/share/jupyter/lab/themes/@jupyterlab/theme-dark-extension/index.js python3-jupyterlab.noarch: E: zero-length /usr/share/jupyter/lab/themes/@jupyterlab/theme-light-extension/index.js python3-jupyterlab.noarch: E: non-executable-script /usr/lib/python3.11/site-packages/jupyterlab/node-version-check.js 644 /usr/bin/env node python3-jupyterlab.noarch: E: non-executable-script /usr/lib/python3.11/site-packages/jupyterlab/staging/yarn.js 644 /usr/bin/env node python3-jupyterlab.noarch: W: no-manual-page-for-binary jlpm python3-jupyterlab.noarch: W: no-manual-page-for-binary jupyter-lab python3-jupyterlab.noarch: W: no-manual-page-for-binary jupyter-labextension python3-jupyterlab.noarch: W: no-manual-page-for-binary jupyter-labhub python3-jupyterlab.noarch: W: hidden-file-or-dir /usr/lib/python3.11/site-packages/jupyterlab/staging/.yarnrc python3-jupyterlab.noarch: W: files-duplicate /usr/lib/python3.11/site-packages/jupyterlab/tests/mock_packages/interop/ consumer/jlab_mock_consumer.py /usr/lib/python3.11/site-packages/jupyterlab/tests/mock_packages/extension/ mock_package.py python3-jupyterlab.noarch: E: backup-file-in-package /usr/lib/python3.11/site-packages/jupyterlab/schemas/@jupyterlab/application- extension/package.json.orig python3-jupyterlab.noarch: E: backup-file-in-package /usr/lib/python3.11/site-packages/jupyterlab/schemas/@jupyterlab/apputils- extension/package.json.orig python3-jupyterlab.noarch: E: backup-file-in-package /usr/lib/python3.11/site-packages/jupyterlab/schemas/@jupyterlab/cell- toolbar-extension/package.json.orig python3-jupyterlab.noarch: E: backup-file-in-package /usr/lib/python3.11/site-packages/jupyterlab/schemas/@jupyterlab/codemirror- extension/package.json.orig python3-jupyterlab.noarch: E: backup-file-in-package /usr/lib/python3.11/site-packages/jupyterlab/schemas/@jupyterlab/ collaboration-extension/package.json.orig python3-jupyterlab.noarch: E: backup-file-in-package /usr/lib/python3.11/site-packages/jupyterlab/schemas/@jupyterlab/completer- extension/package.json.orig python3-jupyterlab.noarch: E: backup-file-in-package /usr/lib/python3.11/site-packages/jupyterlab/schemas/@jupyterlab/console- extension/package.json.orig python3-jupyterlab.noarch: E: backup-file-in-package /usr/lib/python3.11/site-packages/jupyterlab/schemas/@jupyterlab/csvviewer- extension/package.json.orig python3-jupyterlab.noarch: E: backup-file-in-package /usr/lib/python3.11/site-packages/jupyterlab/schemas/@jupyterlab/debugger- extension/package.json.orig python3-jupyterlab.noarch: E: backup-file-in-package /usr/lib/python3.11/site-packages/jupyterlab/schemas/@jupyterlab/docmanager- extension/package.json.orig python3-jupyterlab.noarch: E: backup-file-in-package /usr/lib/python3.11/site-packages/jupyterlab/schemas/@jupyterlab/ documentsearch-extension/package.json.orig python3-jupyterlab.noarch: E: backup-file-in-package /usr/lib/python3.11/site-packages/jupyterlab/schemas/@jupyterlab/ extensionmanager-extension/package.json.orig python3-jupyterlab.noarch: E: backup-file-in-package /usr/lib/python3.11/site-packages/jupyterlab/schemas/@jupyterlab/filebrowser- extension/package.json.orig python3-jupyterlab.noarch: E: backup-file-in-package /usr/lib/python3.11/site-packages/jupyterlab/schemas/@jupyterlab/fileeditor- extension/package.json.orig python3-jupyterlab.noarch: E: backup-file-in-package /usr/lib/python3.11/site-packages/jupyterlab/schemas/@jupyterlab/help- extension/package.json.orig python3-jupyterlab.noarch: E: backup-file-in-package /usr/lib/python3.11/site-packages/jupyterlab/schemas/@jupyterlab/htmlviewer- extension/package.json.orig python3-jupyterlab.noarch: E: backup-file-in-package /usr/lib/python3.11/site-packages/jupyterlab/schemas/@jupyterlab/hub- extension/package.json.orig python3-jupyterlab.noarch: E: backup-file-in-package /usr/lib/python3.11/site-packages/jupyterlab/schemas/@jupyterlab/imageviewer- extension/package.json.orig python3-jupyterlab.noarch: E: backup-file-in-package /usr/lib/python3.11/site-packages/jupyterlab/schemas/@jupyterlab/inspector- extension/package.json.orig python3-jupyterlab.noarch: E: backup-file-in-package /usr/lib/python3.11/site-packages/jupyterlab/schemas/@jupyterlab/launcher- extension/package.json.orig python3-jupyterlab.noarch: E: backup-file-in-package /usr/lib/python3.11/site-packages/jupyterlab/schemas/@jupyterlab/logconsole- extension/package.json.orig python3-jupyterlab.noarch: E: backup-file-in-package /usr/lib/python3.11/site-packages/jupyterlab/schemas/@jupyterlab/lsp- extension/package.json.orig python3-jupyterlab.noarch: E: backup-file-in-package /usr/lib/python3.11/site-packages/jupyterlab/schemas/@jupyterlab/mainmenu- extension/package.json.orig python3-jupyterlab.noarch: E: backup-file-in-package /usr/lib/python3.11/site-packages/jupyterlab/schemas/@jupyterlab/ markdownviewer-extension/package.json.orig python3-jupyterlab.noarch: E: backup-file-in-package /usr/lib/python3.11/site-packages/jupyterlab/schemas/@jupyterlab/ metadataform-extension/package.json.orig python3-jupyterlab.noarch: E: backup-file-in-package /usr/lib/python3.11/site-packages/jupyterlab/schemas/@jupyterlab/notebook- extension/package.json.orig python3-jupyterlab.noarch: E: backup-file-in-package /usr/lib/python3.11/site-packages/jupyterlab/schemas/@jupyterlab/running- extension/package.json.orig python3-jupyterlab.noarch: E: backup-file-in-package /usr/lib/python3.11/site-packages/jupyterlab/schemas/@jupyterlab/ settingeditor-extension/package.json.orig python3-jupyterlab.noarch: E: backup-file-in-package /usr/lib/python3.11/site-packages/jupyterlab/schemas/@jupyterlab/shortcuts- extension/package.json.orig python3-jupyterlab.noarch: E: backup-file-in-package /usr/lib/python3.11/site-packages/jupyterlab/schemas/@jupyterlab/statusbar- extension/package.json.orig python3-jupyterlab.noarch: E: backup-file-in-package /usr/lib/python3.11/site-packages/jupyterlab/schemas/@jupyterlab/terminal- extension/package.json.orig python3-jupyterlab.noarch: E: backup-file-in-package /usr/lib/python3.11/site-packages/jupyterlab/schemas/@jupyterlab/toc- extension/package.json.orig python3-jupyterlab.noarch: E: backup-file-in-package /usr/lib/python3.11/site-packages/jupyterlab/schemas/@jupyterlab/tooltip- extension/package.json.orig python3-jupyterlab.noarch: E: backup-file-in-package /usr/lib/python3.11/site-packages/jupyterlab/schemas/@jupyterlab/translation- extension/package.json.orig python3-jupyterlab.noarch: E: backup-file-in-package /usr/share/jupyter/lab/schemas/@jupyterlab/application-extension/package. json.orig python3-jupyterlab.noarch: E: backup-file-in-package /usr/share/jupyter/lab/schemas/@jupyterlab/apputils-extension/package.json. orig python3-jupyterlab.noarch: E: backup-file-in-package /usr/share/jupyter/lab/schemas/@jupyterlab/cell-toolbar-extension/package. json.orig python3-jupyterlab.noarch: E: backup-file-in-package /usr/share/jupyter/lab/schemas/@jupyterlab/codemirror-extension/package.json. orig python3-jupyterlab.noarch: E: backup-file-in-package /usr/share/jupyter/lab/schemas/@jupyterlab/collaboration-extension/package. json.orig python3-jupyterlab.noarch: E: backup-file-in-package /usr/share/jupyter/lab/schemas/@jupyterlab/completer-extension/package.json. orig python3-jupyterlab.noarch: E: backup-file-in-package /usr/share/jupyter/lab/schemas/@jupyterlab/console-extension/package.json. orig python3-jupyterlab.noarch: E: backup-file-in-package /usr/share/jupyter/lab/schemas/@jupyterlab/csvviewer-extension/package.json. orig python3-jupyterlab.noarch: E: backup-file-in-package /usr/share/jupyter/lab/schemas/@jupyterlab/debugger-extension/package.json. orig python3-jupyterlab.noarch: E: backup-file-in-package /usr/share/jupyter/lab/schemas/@jupyterlab/docmanager-extension/package.json. orig python3-jupyterlab.noarch: E: backup-file-in-package /usr/share/jupyter/lab/schemas/@jupyterlab/documentsearch-extension/package. json.orig python3-jupyterlab.noarch: E: backup-file-in-package /usr/share/jupyter/lab/schemas/@jupyterlab/extensionmanager-extension/ package.json.orig python3-jupyterlab.noarch: E: backup-file-in-package /usr/share/jupyter/lab/schemas/@jupyterlab/filebrowser-extension/package. json.orig python3-jupyterlab.noarch: E: backup-file-in-package /usr/share/jupyter/lab/schemas/@jupyterlab/fileeditor-extension/package.json. orig python3-jupyterlab.noarch: E: backup-file-in-package /usr/share/jupyter/lab/schemas/@jupyterlab/help-extension/package.json.orig python3-jupyterlab.noarch: E: backup-file-in-package /usr/share/jupyter/lab/schemas/@jupyterlab/htmlviewer-extension/package.json. orig python3-jupyterlab.noarch: E: backup-file-in-package /usr/share/jupyter/lab/schemas/@jupyterlab/hub-extension/package.json.orig python3-jupyterlab.noarch: E: backup-file-in-package /usr/share/jupyter/lab/schemas/@jupyterlab/imageviewer-extension/package. json.orig python3-jupyterlab.noarch: E: backup-file-in-package /usr/share/jupyter/lab/schemas/@jupyterlab/inspector-extension/package.json. orig python3-jupyterlab.noarch: E: backup-file-in-package /usr/share/jupyter/lab/schemas/@jupyterlab/launcher-extension/package.json. orig python3-jupyterlab.noarch: E: backup-file-in-package /usr/share/jupyter/lab/schemas/@jupyterlab/logconsole-extension/package.json. orig python3-jupyterlab.noarch: E: backup-file-in-package /usr/share/jupyter/lab/schemas/@jupyterlab/lsp-extension/package.json.orig python3-jupyterlab.noarch: E: backup-file-in-package /usr/share/jupyter/lab/schemas/@jupyterlab/mainmenu-extension/package.json. orig python3-jupyterlab.noarch: E: backup-file-in-package /usr/share/jupyter/lab/schemas/@jupyterlab/markdownviewer-extension/package. json.orig python3-jupyterlab.noarch: E: backup-file-in-package /usr/share/jupyter/lab/schemas/@jupyterlab/metadataform-extension/package. json.orig python3-jupyterlab.noarch: E: backup-file-in-package /usr/share/jupyter/lab/schemas/@jupyterlab/notebook-extension/package.json. orig python3-jupyterlab.noarch: E: backup-file-in-package /usr/share/jupyter/lab/schemas/@jupyterlab/running-extension/package.json. orig python3-jupyterlab.noarch: E: backup-file-in-package /usr/share/jupyter/lab/schemas/@jupyterlab/settingeditor-extension/package. json.orig python3-jupyterlab.noarch: E: backup-file-in-package /usr/share/jupyter/lab/schemas/@jupyterlab/shortcuts-extension/package.json. orig python3-jupyterlab.noarch: E: backup-file-in-package /usr/share/jupyter/lab/schemas/@jupyterlab/statusbar-extension/package.json. orig python3-jupyterlab.noarch: E: backup-file-in-package /usr/share/jupyter/lab/schemas/@jupyterlab/terminal-extension/package.json. orig python3-jupyterlab.noarch: E: backup-file-in-package /usr/share/jupyter/lab/schemas/@jupyterlab/toc-extension/package.json.orig python3-jupyterlab.noarch: E: backup-file-in-package /usr/share/jupyter/lab/schemas/@jupyterlab/tooltip-extension/package.json. orig python3-jupyterlab.noarch: E: backup-file-in-package /usr/share/jupyter/lab/schemas/@jupyterlab/translation-extension/package. json.orig
I can remove all the hidden, empty, and backup files and see what impact it'll have.