Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=746438
Vít Ondruch vondruch@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |vondruch@redhat.com
--- Comment #1 from Vít Ondruch vondruch@redhat.com 2011-11-28 05:53:35 EST --- * Update to the latest version - Time is passing fast, could you please update to the latest version?
* Is it worth of including ruby- subpackage? - Isn't this re-review good opportunity to get rid of the ruby- subpackage? The design is flawed IMO and doesn't bring anything of benefit for users.
* Remove the -devel subpackage. - Is the -devel package required? Will somebody prepare some other library with binary extension which will depend on cairo? What is your opinion?
* defattr macros are no longer necessary - https://fedoraproject.org/wiki/Packaging:Guidelines#File_Permissions
* Use ruby(rubygems) virtual provide preferably
* The license should be Ruby or GPLv2 - Since the COPYING file states "distributed under the same conditions as ruby", the license should be adjusted appropriately.