https://bugzilla.redhat.com/show_bug.cgi?id=1316664
Petr Pisar ppisar@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+
--- Comment #3 from Petr Pisar ppisar@redhat.com --- Spec file changes:
--- perl-List-SomeUtils-XS.spec.old 2016-03-10 18:21:03.000000000 +0100 +++ perl-List-SomeUtils-XS.spec 2016-03-29 12:10:59.000000000 +0200 @@ -1,8 +1,8 @@ Name: perl-List-SomeUtils-XS Version: 0.51 -Release: 1%{?dist} +Release: 2%{?dist} Summary: XS implementation for List::SomeUtils -License: Artistic 2.0 +License: Artistic 2.0 and (GPL+ or Artistic) URL: http://search.cpan.org/dist/List-SomeUtils-XS/ Source0: http://www.cpan.org/authors/id/D/DR/DROLSKY/List-SomeUtils-XS-%%7Bversion%7D... BuildRequires: findutils @@ -37,12 +37,10 @@ Requires: perl(XSLoader)
%description -There are no user-facing parts here. See List::SomeUtils for API details. +List::SomeUtils provides some trivial but commonly needed functionality on +lists which is not going to go into List::Util.
-You shouldn't have to install this module directly. When you install -List::SomeUtils, it checks whether your system has a compiler. If it does, -then it adds a dependency on this module so that it gets installed and you -have the faster XS implementation. +XS implementation is faster than List::SomeUtils.
%prep %setup -q -n List-SomeUtils-XS-%{version} @@ -67,5 +65,8 @@ %{_mandir}/man3/*
%changelog +* Tue Mar 29 2016 Jitka Plesnikova jplesnik@redhat.com - 0.51-2 +- Updated license and description + * Thu Mar 10 2016 Jitka Plesnikova jplesnik@redhat.com - 0.51-1 - Initial release
TODO: I had bad feeling about the description. It describes internal representation that is not relevant to binary RPM package (perl-List-SomeUtils binary RPM does not check for a compiler etc.).
%description -There are no user-facing parts here. See List::SomeUtils for API details. +List::SomeUtils provides some trivial but commonly needed functionality on +lists which is not going to go into List::Util.
-You shouldn't have to install this module directly. When you install -List::SomeUtils, it checks whether your system has a compiler. If it does, -then it adds a dependency on this module so that it gets installed and you -have the faster XS implementation. +XS implementation is faster than List::SomeUtils. Ok.
FIX: Artistic 2.0 license verified from README.md, lib/List/SomeUtils/XS.pm, LICENSE. But there is the bundled ppport.h (GPL+ or Artistic) that is compiled into the binary file. I think correct license tag is "Artistic 2.0 and (GPL+ or Artistic)".
-License: Artistic 2.0 +License: Artistic 2.0 and (GPL+ or Artistic) Ok.
$ rpmlint perl-List-SomeUtils-XS.spec ../SRPMS/perl-List-SomeUtils-XS-0.51-2.fc25.src.rpm ../RPMS/x86_64/perl-List-SomeUtils-XS-*2.* perl-List-SomeUtils-XS.src: W: spelling-error %description -l en_US Util -> Til, U til, Until perl-List-SomeUtils-XS.x86_64: W: spelling-error %description -l en_US Util -> Til, U til, Until 3 packages and 1 specfiles checked; 0 errors, 2 warnings. rpmlint is Ok.
Package builds in F25 (http://koji.fedoraproject.org/koji/taskinfo?taskID=13494781). Ok.
Resolution: Package APPROVED.