https://bugzilla.redhat.com/show_bug.cgi?id=1431322
Robin Lee <robinlee.sysu(a)gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Flags|fedora-review? |fedora-review+
--- Comment #5 from Robin Lee <robinlee.sysu(a)gmail.com> ---
1. There are still three whitespaces at EOLs.
2. Description of data subpackage should end with a period.
3. A comment should be included to specify which file is under BSD.
https://fedoraproject.org/wiki/Packaging:LicensingGuidelines?rd=Packaging...
4. License and documents can be included only in the data subpackage. since it
is required by the base one.
5. update-desktop-database should not be used in Fedora 25 or later. You can
make a condition to filter some statements out:
%if 0%{?fedora} < 25
xxxx
%endif
After all, these are not blocking conditions. Just fix them before importing
the package.
This package is approved by cheeselee.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component