Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Merge Review: sharutils
https://bugzilla.redhat.com/show_bug.cgi?id=226418
bugzilla@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |medium Priority|normal |medium Product|Fedora Extras |Fedora
pertusus@free.fr changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |pertusus@free.fr
------- Additional Comments From pertusus@free.fr 2007-10-05 08:11 EST ------- Additionally some issues:
.gz in install-info scriptlets should be removed.
You can add INSTALL='install -p' or the like to keep the timestamps of the man pages.
There are checks, they should certainly be run in %check with make check
I don't think that the following line, in the description is useful:
Install sharutils if you send binary files through e-mail.
rpmlint is not silent:
sharutils.src:10: W: prereq-use /sbin/install-info sharutils.src:158: W: macro-in-%changelog defattr sharutils.src: W: summary-ended-with-dot The GNU shar utilities for packaging and unpackaging shell archives. sharutils.src: W: invalid-license GPL sharutils.i386: W: file-not-utf8 /usr/share/doc/sharutils-4.6.3/TODO sharutils.i386: W: file-not-utf8 /usr/share/doc/sharutils-4.6.3/THANKS sharutils.i386: W: summary-ended-with-dot The GNU shar utilities for packaging and unpackaging shell archives. sharutils.i386: W: invalid-license GPL sharutils-debuginfo.i386: W: invalid-license GPL
A suggestion: replace %defattr(-,root,root) with %defattr(-,root,root,-)