Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=886903
Simone Caronni negativo17@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED
--- Comment #18 from Simone Caronni negativo17@gmail.com --- 1) Can you please put each BuildRequires and Requires (including subpackages) on separate lines and possibly in alphabetic order? This makes the spec file much more readable.
I would prefer also to have the various tags (Name: Release: etc.) and values separated by some tab if possible, but this is only my opinion.
2) Is opengl-games-utils required? Although preferable to have 3d acceleration the game should run also through software rendering.
3) Should the vendor parameter be removed from desktop-file install calls? According to the package guidelines [1] the vendor should only be supplied if the package has already the vendor in place, but this is a new package or replacement.
4) Macros should not be used unless necessary [2], I think %{__rm}, %{__install}, %{__mkdir_p} and %{__sed} should be removed.
5) Please remove the comment at line 106 (#%patch0 -p0).
6) The commands "install" and "cp" should use "-p" to preserve timestamps where possible.
[1] http://fedoraproject.org/wiki/Packaging:Guidelines#desktop-file-install_usag... [2] http://fedoraproject.org/wiki/Packaging:Guidelines#Macros