https://bugzilla.redhat.com/show_bug.cgi?id=1219288
--- Comment #8 from Julien Enselme jujens@jujens.eu --- - In the python3 section of BR, you wrote 'BuildRequires: python-ordered-set' but I think you meant 'BuildRequires: python3-ordered-set' (I cannot launch tests for python3 because this dependency is missing). - You can simplify:
%if %{with python3} %package -n python3-%{upstream_name} Summary: Python 3 library for converting complex datatypes to and from primitive types %if %{with python3} Requires: python3-dateutil Requires: python3-ordered-set %endif
into (you already are in a python3 only section, no need to specify it again)
%if %{with python3} %package -n python3-%{upstream_name} Summary: Python 3 library for converting complex datatypes to and from primitive types Requires: python3-dateutil Requires: python3-ordered-set
- The use of %py3dir is deprecated. Python2 and python3 packages should be built from the same folder. The build and installation process should respectively rely on %py2_build/%py3build and %py2_install/%py3_install. See https://fedoraproject.org/wiki/Packaging:Python#Example_common_spec_file for an example.
- I think it would be clearer to remove ordereddict and orderedset in %prep rather than in %install after the package is installed
- Maybe move part of the doc (%{_docdir}/python-%{upstream_name}) into a -doc subpackage which could be used for both python2 and python3.
- You are packaging a pre-release (the latest stable release would be fine too), so you release tag is incorrect. See: https://fedoraproject.org/wiki/Packaging:NamingGuidelines#Snapshot_packages