https://bugzilla.redhat.com/show_bug.cgi?id=2275305
Sandro gui1ty@penguinpee.nl changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-review? Assignee|nobody@fedoraproject.org |gui1ty@penguinpee.nl CC| |gui1ty@penguinpee.nl Doc Type|--- |If docs needed, set a value Status|NEW |ASSIGNED
--- Comment #1 from Sandro gui1ty@penguinpee.nl --- I'm taking this. Seems I might need it for another package I'm working on.
Glancing over the spec file, I have the following preliminary remarks:
In `setup.py` upstream defines extra `preview`. That should be packaged as such. See:
https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/#Extras
However, since glfw-preview [1] is not yet packaged for Fedora, you can leave out the extra. On the other hand, `glfw-preview` uses the same source as `glfw`, so it seems reasonable to package that as well. It should probably be a package of its own, but I'll check on that.
You should use the modern Python (pyproject) macros described in [2], unless there's a compelling reason for using the older macros [3]. Using the modern macros, you should not need to specify any Provides or Requires. They will be detected and added automatically. You have `Requires: python3dist(glfw-preview)`. That seems wrong since only the optional `preview` extra requires it. It also causes the package not to install since nothing provides `python3dist(glfw-preview)`.
The modern macros will also make it easy to populate the `%files` section (see [4]).
Lastly, please consider defining a macro for the description instead of repeating the content. See the example spec file [4] for inspiration. It will make maintaining the spec file easier.
[1] https://pypi.org/project/glfw-preview/ [2] https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/ [3] https://docs.fedoraproject.org/en-US/packaging-guidelines/Python_201x/ [4] https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/#_example_s...