https://bugzilla.redhat.com/show_bug.cgi?id=1872867
Jaroslav Škarvada jskarvad@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-review+
--- Comment #15 from Jaroslav Škarvada jskarvad@redhat.com --- Thanks, there are two more minor things, please fix them before including the package, but I am approving the package now:
- %config(noreplace) /etc/sysconfig/stalld You should use macro, e.g.: %config(noreplace) %{_sysconfdir}/sysconfig/stalld
- it seems you used commas instead of periods in the changelog, e.g. (redhat,com, instad of redhat.com): * Mon Aug 31 2020 williams@redhat,com - 1.0-2 - use _docdir macro for README.md - use _mandir macro for stalld.8 manpage - use tabs for spacing - added push Makefile target to copy latest to upstream URL
* Tue Aug 25 2020 williams@redhat,com - 1.0-1 - rename project to stalld - set version to 1.0 - clean up rpmlint complaints