Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: gtk-nodoka-engine - The Nodoka gtk engine
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=248163
------- Additional Comments From martin.sourada@seznam.cz 2007-07-27 14:41 EST ------- (In reply to comment #2)
Some trivia:
- version of spec file and src.rpm don't match
Hm... I see both are 0.3.2.1-1 though Daniel meanwhile updated the src.rpm to 0.5-1. I'll fix the other things in next release and they should match by then.
- please use a full src url, if practical
As we use wiki currently for upstream I think it's impractical ATM
- no need to do the obsoletes/provides dance for something that has not ever
been in a fedora release.
I'll remove them in next release. They were there because older releases were differently handled and I provided the rpms for testing to community and so I added obsoletes/provides for easier upgrade
- please don't --enable-animation. I as the gtk2 maintainer am going to veto
any theme engine that tries to do that behind the toolkits or apps back.
I don't prefer the animation myself so I am OK with that... will remove it in next release. But on the other side... I noticed the Murrine engine has the animation enabled as well and the code behind is exactly the same as in Nodoka engine.
- need to require gtk2 for the engines directory ownership
I will add it in next release. I missed it.