Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: perl-MP3-Info - Manipulate / fetch info from MP3 audio files
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=196531
tibbs@math.uh.edu changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|bugzilla-sink@leemhuis.info |tibbs@math.uh.edu OtherBugsDependingO|163776 |163779 nThis| |
------- Additional Comments From tibbs@math.uh.edu 2006-06-26 11:12 EST ------- Builds fine in mock and rpmlint is silent.
Note that BuildRequires: perl is not necessary.
I see no blockers; everything looks good.
Review: * package meets naming and packaging guidelines. * specfile is properly named, is cleanly written and uses macros consistently. * dist tag is present. * build root is correct. * license field matches the actual license. * license is open source-compatible. License text not included upstream. * source files match upstream: ffb3427089a6b5f56e35e5b2ab902d29 MP3-Info-1.20.tar.gz * latest version is being packaged. * BuildRequires are proper. * package builds in mock (development, x86_64). * rpmlint is silent. * final provides and requires are sane: perl(MP3::Info) = 1.20 perl-MP3-Info = 1.20-1.fc6 = perl >= 0:5.006 perl(:MODULE_COMPAT_5.8.8) perl(Carp) perl(bytes) perl(overload) perl(strict) perl(vars) * no shared libraries are present. * package is not relocatable. * owns the directories it creates. * doesn't own any directories it shouldn't. * no duplicates in %files. * file permissions are appropriate. * %clean is present. * %check is present and all tests pass: All tests successful. Files=4, Tests=246, 1 wallclock secs ( 0.23 cusr + 0.08 csys = 0.31 CPU) * no scriptlets present. * code, not content. * documentation is small, so no -docs subpackage is necessary. * %docs are not necessary for the proper functioning of the package. * no headers. * no pkgconfig files. * no libtool .la droppings. * not a GUI app.
APPROVED