[Bug 498371] Review Request: fedora-devshell - Fedora Developer's Toolbox

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=498371

--- Comment #1 from Jussi Lehtola   2009-04-30 16:56:02 EDT ---
A few initial comments:

- Don't use macros in the URL, since this makes copy-pasteing impossible (well,
at least awkward) from the specfile.

- I see you're also upstream.
 %attr(755,root,root) %{_bindir}/ports
 %attr(755,root,root) %{_bindir}/devshell
should be just
 %{_bindir}/ports
 %{_bindir}/devshell
with the 755 flags set by the install script (setup.py).

I'll do the review tomorrow.