Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=603346
--- Comment #3 from Lev Shamardin shamardin@gmail.com 2011-06-04 16:34:03 EDT --- 1. /etc/httpd/conf.d/pva.conf contains %DATADIR% macros inside, must be fixed.
2. I think you should either add
Requires: voms-server
or consider adding README.Fedora stating that voms-server package (possibly on some other host) is required for using this software.
3. Looks like /usr/share/pva/.htaccess is redundant, since pva.conf already contains these rewrites.
4. After first fix mentioned above, the package does NOT work on my Fedora 14 x86_64 box, with these errors in ssl_error_log:
[Sun Jun 05 00:30:26 2011] [error] [client 127.0.0.1] PHP Notice: Undefined variable: voms_str_unauth in /usr/share/pva/index.php on line 58 [Sun Jun 05 00:30:26 2011] [error] [client 127.0.0.1] PHP Notice: Undefined variable: voms_title in /usr/share/pva/index.php on line 90 [Sun Jun 05 00:30:26 2011] [error] [client 127.0.0.1] PHP Notice: Undefined variable: regex_digits in /usr/share/pva/index.php on line 112 [Sun Jun 05 00:30:26 2011] [error] [client 127.0.0.1] PHP Warning: preg_match(): Empty regular expression in /usr/share/pva/index.php on line 112
5. As the added bonus, would you consider upgrading to a newer SVN version, or at least include lang/ru.inc into the package. (I will not require this, but it would be very nice.)
Now, the formal part:
MUST items:
- MUST: rpmlint errors: php-voms-admin.noarch: E: htaccess-file /usr/share/pva/.htaccess + MUST: package is named according to guidelines. + MUST: spec file name is correct. + MUST: The package must meet the Packaging Guidelines . + MUST: package is licensed under ASL 2.0 + MUST: The License field in the package spec file does match the actual license. + MUST: The license text file is included into the source and the package. + MUST: The spec file must is written in American English. + MUST: The spec file for the package is legible. + MUST: Provided sources match the upstream SVN. + MUST: The package builds on noarch. + MUST: Package does not need any Build dependencies. + MUST: Source package does not use gettext locales. + MUST: Package does not contain shared libraries. + MUST: Package does not bundle copies of system libraries. + MUST: Package is not relocatable. + MUST: Package owns all directories it creates. + MUST: %files listings are fine. + MUST: Permissions on files are correct. + MUST: Package consistently uses macros. + MUST: The package contains code, or permissable content. + MUST: Package does not contain large documentation. + MUST: Package %doc does not affect the runtime. + MUST: Package does not own files or directories owned by other packages. + MUST: All filenames in rpm package are valid UTF-8.
SHOULD items:
+ SHOULD: Source package includes the license text. + SHOULD: Package builds in mock. - SHOULD: At the moment the package functionality seems to be broken, but this seems to be an upstream issue. Some svn revisions ago it did work. - SHOULD: Manual page for /usr/sbin/pva-addvo is missing in upstream.