Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=753855
Parag AN(पराग) panemade@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |panemade@gmail.com AssignedTo|nobody@fedoraproject.org |panemade@gmail.com Flag| |fedora-review?
--- Comment #1 from Parag AN(पराग) panemade@gmail.com 2011-11-16 01:29:05 EST --- Review:-
+ koji build -> http://koji.fedoraproject.org/koji/taskinfo?taskID=3518017 + rpmlint on package gave pslib.src: W: spelling-error %description -l en_US png -> pg, ping, pang pslib.src: W: spelling-error %description -l en_US eps -> esp, rps, es pslib.src: W: spelling-error %description -l en_US kerning -> keening, kenning, Kettering pslib.src: W: spelling-error %description -l en_US pdfmarks -> pockmarks pslib.src: W: spelling-error %description -l en_US ghostscript's -> ghost script's, ghost-script's, postscript's pslib.src: W: spelling-error %description -l en_US pdfwriter -> typewriter pslib.x86_64: W: spelling-error %description -l en_US png -> pg, ping, pang pslib.x86_64: W: spelling-error %description -l en_US eps -> esp, rps, es pslib.x86_64: W: spelling-error %description -l en_US kerning -> keening, kenning, Kettering pslib.x86_64: W: spelling-error %description -l en_US pdfmarks -> pockmarks pslib.x86_64: W: spelling-error %description -l en_US ghostscript's -> ghost script's, ghost-script's, postscript's pslib.x86_64: W: spelling-error %description -l en_US pdfwriter -> typewriter pslib.x86_64: W: shared-lib-calls-exit /usr/lib64/libps.so.0.4.5 exit@GLIBC_2.2.5 pslib.x86_64: W: spurious-executable-perm /usr/share/doc/pslib-0.4.5/ChangeLog pslib.x86_64: E: incorrect-fsf-address /usr/share/doc/pslib-0.4.5/COPYING pslib.x86_64: W: file-not-utf8 /usr/share/doc/pslib-0.4.5/AUTHORS pslib.x86_64: E: zero-length /usr/share/doc/pslib-0.4.5/NEWS pslib-devel.x86_64: W: no-documentation 3 packages and 0 specfiles checked; 2 errors, 16 warnings.
+ source match with upstream source as (sha1sum) 2ad904b650b7d55b7c12be0c99f77073770ece56 pslib-0.4.5.tar.gz 2ad904b650b7d55b7c12be0c99f77073770ece56 ../SOURCES/pslib-0.4.5.tar.gz
+ Package :pslib-0.4.5-1.fc17.x86_64 Provides: libps.so.0()(64bit) Requires: libc.so.6()(64bit) libc.so.6(GLIBC_2.11)(64bit) libc.so.6(GLIBC_2.14)(64bit) libc.so.6(GLIBC_2.2.5)(64bit) libc.so.6(GLIBC_2.3)(64bit) libc.so.6(GLIBC_2.3.4)(64bit) libc.so.6(GLIBC_2.4)(64bit) libc.so.6(GLIBC_2.7)(64bit) libjpeg.so.62()(64bit) libjpeg.so.62(LIBJPEG_6.2)(64bit) libpng15.so.15()(64bit) libpng15.so.15(PNG15_0)(64bit) libtiff.so.3()(64bit) rtld(GNU_HASH)
Package : pslib-devel-0.4.5-1.fc17.x86_64 Provides: pkgconfig(libps) = 0.4.5 Requires: /usr/bin/pkg-config libps.so.0()(64bit)
+ libps.pc file is present.
Suggestions: 1) remove the zero-length file NEWS 2) for the incorrect-fsf-address, you can contact upstream and ask them to correct in COPYING file 3) AUTHORS is not a utf8 file, you can make it utf8 as given at http://fedoraproject.org/wiki/Packaging_tricks#Convert_encoding_to_UTF-8 4) To remove executable permissions on ChangeLog use http://fedoraproject.org/wiki/Packaging_tricks#Exec_permission 5) you don't need to clean buildroot in %install 6) I think license is LGPLv2+ and MPL and MIT
See http://fedoraproject.org/wiki/Packaging:LicensingGuidelines#Multiple_Licensi...