https://bugzilla.redhat.com/show_bug.cgi?id=1209974
Raphael Groner projects.rg@smart.ms changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |projects.rg@smart.ms Blocks| |928937 (qt-reviews) Assignee|nobody@fedoraproject.org |projects.rg@smart.ms Flags| |fedora-review?
--- Comment #6 from Raphael Groner projects.rg@smart.ms --- As a first step, I've some general hints to your spec file: - Is there support for Qt5? Please notice that upstream announced to stop further development for Qt4.
- Remove the Group: tag, it's obsolete.
- You can shorten the Source URL: Source0: %{url}/dist/%{name}-%{version}.tar.gz
- You can use %make_build, instead of: make %{?_smp_mflags}
- Maybe use also %make_install, instead of: make install DESTDIR=%{buildroot}
- %defattr is not needed, please remove that line from %files.
- Use %{name} where applicable for the file names: %{_bindir}/%{name} %{_mandir}/man1/%{name}.1* %{_datadir}/applications/%{name}.desktop
- You can skip the compression of manpage in cmake. The compression method may change and rpmbuild does that automatically, so it is important to reference the pages in the %files section with a pattern that takes this into account. https://fedoraproject.org/wiki/Packaging:Guidelines#Manpages
- Use desktop-file-validate for the installed desktop file. https://fedoraproject.org/wiki/Packaging:Guidelines#desktop-file-install_usa...
- Install the application icon in hicolor icons folder and include the scriptlets. https://fedoraproject.org/wiki/Packaging:ScriptletSnippets#Icon_Cache
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=928937 [Bug 928937] Qt-related package review tracker