https://bugzilla.redhat.com/show_bug.cgi?id=1901000
--- Comment #2 from Mattia Verga mattia.verga@protonmail.com --- (In reply to Andy Mender from comment #1)
I noticed that the extra subpackages use "+" as a separator. Shouldn't they use "-" instead or are these flavors of the -server package?
That's the way Fedora has chosen to name the extras provided by the package. Everything is made automatically by the macro: https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/#_python_ex...
Name: python-%{srcname} Version: 3.0.0 Release: 1.b2%{?dist}
The "b2" part should be in the Version field, I think. It's not a part of the Fedora package Release tag, but rather of the version string of the upstream package.
No, 3.0.0b2 does not sort properly, since 3.0.0 will be lower: https://docs.fedoraproject.org/en-US/packaging-guidelines/Versioning/#_unsor... 'b2' must go in <extraver>.
Upstream provides tests in the PyPi tarball. Can these be added to the SPEC file under %check or do they require external binaries, like a server daemon?
Can't run tests, since sanic package isn't available
The rest looks okay. Package approved.
Thank you!