Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: galago-daemon
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=189609
jpmahowald@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|bugzilla-sink@leemhuis.info |jpmahowald@gmail.com OtherBugsDependingO|163776 |163779 nThis| |
------- Additional Comments From jpmahowald@gmail.com 2006-05-17 16:13 EST ------- - rpmlint checks return: W: galago-daemon non-conffile-in-etc /etc/dbus-1/system.d/galago-daemon.conf A non-executable file in your package is being installed in /etc, but is not a configuration file. All non-executable files in /etc should be configuration files. Mark the file as %config in the spec file.
W: galago-daemon non-standard-dir-in-usr libexec Non standard but not without precedent. I'm inclined to ignore.
- package meets naming guidelines - package meets packaging guidelines - license (GPL) OK, text in %doc, matches source - spec file legible, in am. english - source matches upstream - package compiles on FC5 (x86_64) - no missing BR - no unnecessary BR - no locales - not relocatable - owns all directories that it creates - no duplicate files - permissions ok - %clean ok - macro use consistent - code, not content - no need for -docs - nothing in %doc affects runtime - no need for .desktop file
Mark the config file as %config
APPROVED