Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=568149
Ionuț Arțăriși mapleoin@lavabit.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |mapleoin@lavabit.com Flag| |fedora-review?
--- Comment #1 from Ionuț Arțăriși mapleoin@lavabit.com 2010-02-27 13:00:36 EST --- Hello,
Here's my review:
$ rpmlint RPMS/noarch/RunSnakeRun-2.0.0-0.1.b4.fc12.noarch.rpm RunSnakeRun.noarch: W: spelling-error %description -l en_US cProfile -> c Profile, profile, profitless RunSnakeRun.noarch: W: spelling-error %description -l en_US profiler -> profile, profiles, profiled RunSnakeRun.noarch: W: spelling-error %description -l en_US sortable -> portable, sort able, sort-able RunSnakeRun.noarch: W: no-documentation RunSnakeRun.noarch: E: non-executable-script /usr/lib/python2.6/site-packages/runsnakerun/runsnake.py 0644 /usr/bin/python 1 packages and 0 specfiles checked; 1 errors, 4 warnings.
- The license in license.txt should be included in the %doc section of %files - Please remove the shebang from /usr/lib/python2.6/site-packages/runsnakerun/runsnake.py - All GUI applications must include a desktop entry [1] - Small suggestion: there's a missing dot at the end of the %description.
[1] http://fedoraproject.org/wiki/Packaging/Guidelines#Desktop_files