https://bugzilla.redhat.com/show_bug.cgi?id=1547757
--- Comment #3 from Robert-André Mauchin zebob.m@gmail.com --- (In reply to Brett Lentz from comment #2)
New spec & srpm at the url in comment #1.
One package is missing for it to be successful, python-tree_format: https://pypi.python.org/pypi/tree-format Package it then add it to the dependencies list:
This is a documentation dependency and not a run-time dependency. This missing dependency does not affect the running of the package.
But that's your job as a packager to package the missing dependencies. You'll end up with broken docs, which are an integral part of the package.
- Why %{_bindir}/%{pkgname} included in the python3 package? This seems curious to have a python3 package with only the binary.
Because that's what is requested in https://fedoraproject.org/wiki/Packaging:Python#Executables_in_.2Fusr.2Fbin
"If the executables provide the same functionality independent of whether they are run on top of Python 2 or Python 3, then only the Python 3 version of the executable should be packaged."
Yes but your Python 3 package is behind a conditional, so if you don't build with Python3, you should put the binary inside the Python 2 package.
- You should also run the tests provided when you have managed to gather all dependencies.
As stated in https://fedoraproject.org/wiki/Packaging:Guidelines#Test_Suites running test suites should be run when practical.
Similar to the tree-format dependency, there are dependencies for the tests that are not currently in Fedora. So, running the tests is currently impractical.
For now it is impractical because it depends on other maintainers to do their job, but as soon as the deps are updated, you should add the tests.