https://bugzilla.redhat.com/show_bug.cgi?id=1919349
--- Comment #7 from d.hatayama@fujitsu.com --- Dominik, Lianbo,
Thanks for your comments.
I've updated the spec file and source rpm file.
Spec URL: https://raw.githubusercontent.com/d-hatayama/crash-modules-fedora-package-re... SRPM URL: https://github.com/d-hatayama/crash-modules-fedora-package-review/raw/master...
(In reply to Dominik 'Rathann' Mierzejewski from comment #5)
You're still using plain 'make' instead of %make_build . Is there a reason?
In %install, please use install -dm755 instead of mkdir -p to avoid depending on the build environment's umask being 022.
Just as BZ#1919347, I didn't update the spec file.
I confirmed this time both files.
(In reply to lijiang from comment #6)
Hi, Hatayama
I just noticed that you had updated them in the source rpm package, but seems that it has been forgotten to update the crash-trace-command.spec?
Thanks for pointing that.
BTW: I have the same questions(see comment#8 bz1919347) about the dependencies of packages.
As I already commented at https://bugzilla.redhat.com/show_bug.cgi?id=1919347#c9, I don't think such dependencies are necessary for crash-trace-command.
Thanks. HATAYAMA, Daisuke