Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: mathmap - A gimp plugin and commandline tool
https://bugzilla.redhat.com/show_bug.cgi?id=431161
------- Additional Comments From mtasaka@ioa.s.u-tokyo.ac.jp 2008-02-08 10:06 EST ------- * compiler falgs - Well, what "Fedora specific compilation flags are not honored" means is related to "Compiler flags" of http://fedoraproject.org/wiki/Packaging/Guidelines When using gcc or g++, we must ensure that the compiler option specified as %optflags are correctly used. On rawhide i386 system, currently they are: ----------------------------------------------------------------------------- [tasaka1@localhost ~]$ rpm --eval %optflags -O2 -g -pipe -Wall -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector --param=ssp-buffer-size=4 -m32 -march=i386 -mtune=generic -fasynchronous-unwind-tables ------------------------------------------------------------------------------ However the build log (from: http://koji.fedoraproject.org/koji/taskinfo?taskID=402716 ) shows: ------------------------------------------------------------------------------- gcc -I. -D_GNU_SOURCE -DCGEN_CC=""gcc -O2 -c -fPIC -o"" -DCGEN_LD=""gcc -shared -o"" -O2 -Wall `gimptool-2.0 --cflags` `pkg-config --cflags gmodule-2.0 gthread-2.0 gtksourceview-1.0` -DLOCALEDIR="/usr/local/share/locale" -DTEMPLATE_DIR="`gimptool-2.0 --gimpdatadir`/mathmap" -DPIXMAP_DIR="`gimptool-2.0 --gimpdatadir`/mathmap" -DENABLE_NLS -DMATHMAP_CMDLINE -DGIMPDATADIR="`gimptool-2.0 --gimpdatadir`" -DMATHMAP_VERSION="1.2.4" -DRWIMG_JPEG -DRWIMG_PNG -DRWIMG_GIF -o mathmap_common.o -c mathmap_common.c ------------------------------------------------------------------------------- , where %optflags are not correctly honored.
* LOCALEDIR - And as far as I checked build.log, perhaps LOCALEDIR is wrong.