Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=551651
ELMORABITY Mohamed melmorabity@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |melmorabity@fedoraproject.o | |rg
--- Comment #1 from ELMORABITY Mohamed melmorabity@fedoraproject.org 2010-01-01 06:49:27 EDT --- Hi,
here is an informal review of your package, while waiting to be sponsored ^^. Just a few remarks, the general look of the .spec seems pretty good ^^.
Be very careful, your binary is not build using the Fedora Project flags currently: see this piece of build log that shows it: + /usr/bin/make linux gcc -g -g -Wall -Werror -lpthread -lpcap -ldnet -lnet -L/usr/local/lib -I/usr/local/include -DLINUX -o arpon arpon.c + exit 0
You must specify these flags in your make command, like this: %build %{__make} CFLAGS="$RPM_OPT_FLAGS" linux
By the way, you should leave in make the parallel build option by default: %build %{__make} %{?_smp_mflags} CFLAGS="$RPM_OPT_FLAGS" linux No particular reason to skip it in my opinion, even if there is only one file to compile... For the moment ^^.
You should also remove the INSTALL file, it is useless if delivered with a package ^^ See https://fedoraproject.org/wiki/Packaging/Guidelines#Documentation