Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=470792
Orcan 'oget' Ogetbil orcanbahri@yahoo.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |orcanbahri@yahoo.com
--- Comment #1 from Orcan 'oget' Ogetbil orcanbahri@yahoo.com 2008-11-25 01:46:21 EDT --- I made a quick check. There is this issue that needs to be corrected before we can do a full review:
* Source0 must be given in full URL from upstream's website.
A few other things that I caught were:
* For the Group tag pick something from /usr/share/doc/rpm-*/GROUPS Development/Tools or Development/Languages maybe?
* %eclipse_base must be %define eclipse_base %{_datadir}/eclipse Check: http://fedoraproject.org/wiki/Packaging/EclipsePlugins Otherwise the package will not build.
* No %doc files? Check the source thoroughly. Please list every applicable file in %doc.
* Use CPL for the license
* There shouldn't be both spaces and tabs in the same SPEC file. Please use one or the other. rpmlint is a good application which will warn you about such things and many other issues.