https://bugzilla.redhat.com/show_bug.cgi?id=1832562
Michael Schwendt bugs.michael@gmx.net changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |bugs.michael@gmx.net
--- Comment #6 from Michael Schwendt bugs.michael@gmx.net --- This review request is a bit of a mystery. The spec file contains a few grave mistakes that have been introduced since the older version found at: https://pagure.io/tpcclib/blob/master/f/tpcclib.spec
%package devel Summary: Libraries files for tpcclib development # Upstream only provides static libraries Provides: %{name}-static%{?_isa} = %{version}-static
Carefully follow
https://docs.fedoraproject.org/en-US/packaging-guidelines/#_packaging_static...
since right now you would be unable to "BuildRequires: tpcclib-static" as per https://docs.fedoraproject.org/en-US/packaging-guidelines/#_statically_linki...
Also notice these two:
https://docs.fedoraproject.org/en-US/packaging-guidelines/#_requiring_base_p...
https://docs.fedoraproject.org/en-US/packaging-guidelines/LicensingGuideline...
%files devel %{_includedir}/*.a %{_includedir}/*.h
Static libraries belong into %{_libdir}
Currently, there are 34 static libraries and 34 header files. Can you tell a bit more about the usage scenario of this package? What external software does (or will) use these libs? Each of the header files includes a missing "tpcclibConfig.h" which indicates that these likely are internal headers and libs and not a public API.