Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=691317
--- Comment #6 from Richard Hughes rhughes@redhat.com 2011-03-31 10:46:57 EDT --- (In reply to comment #5)
bundled libraries]] bundles RPly: http://w3.impa.br/~diego/software/rply/
I've sent a patch upstream to the mash project to use the system rply -- and included that patch in version -2. This means that although rply is in the mash tarball, the system version is used. I've therefore added rply-devel as a BR.
- [-] Spec legible
the word 'Mash' probably should not be in the summary (rpmlint does not catch it because it's not libmash)
Fixed in -2.
- [-] BRs complete
There's an optional dependency on libmx, should it not be added as a BR?
It's only used by the not-installed demo lighting program, and I've added a note in -2 about the "missing" dep.
- [-] Directory ownership - girepository-1.0 is owned by gdk-pixbuf2 so it's probably OK - but %{_datadir}/gir-1.0 is not owned by any package pulled in
by mash
I think it's best to own both in this case, which I've done in -2.
- [-] %buildroot cleaned on %install
This still needs to be done
This package is suitable for F15 and rawhide, so no need for F10 and below compatibility.
- [-] Relevant docs packaged Shouldn't README be included?
Good catch, thanks. Fixed in -2.
New SRPM: http://people.freedesktop.org/~hughsient/temp/libmash-0.1.0-2.fc15.src.rpm New Spec: http://people.freedesktop.org/~hughsient/temp/libmash.spec New Koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=2963688
The rpmlint output is unchanged. Thanks for the super-quick review!
Richard.