https://bugzilla.redhat.com/show_bug.cgi?id=1358956
--- Comment #1 from Marcin Zajaczkowski mszpak@wp.pl --- I applied a workaround for the issue with Rpath, but there are still some fedora-review/rpmlint issues:
Rpmlint ------- Checking: sstp-client-1.0.10-5.fc24.x86_64.rpm sstp-client-devel-1.0.10-5.fc24.x86_64.rpm sstp-client-debuginfo-1.0.10-5.fc24.x86_64.rpm sstp-client-1.0.10-5.fc24.src.rpm sstp-client.x86_64: W: spelling-error %description -l en_US pptp -> PT sstp-client.x86_64: W: spelling-error %description -l en_US pon -> pin, pom, on sstp-client.x86_64: W: spelling-error %description -l en_US poff -> off, toff, poof sstp-client.x86_64: E: missing-call-to-setgroups-before-setuid /usr/sbin/sstpc sstp-client.x86_64: E: missing-call-to-chdir-with-chroot /usr/sbin/sstpc sstp-client.x86_64: W: dangerous-command-in-%postun rm sstp-client-devel.x86_64: W: only-non-binary-in-usr-lib sstp-client.src: W: spelling-error %description -l en_US pptp -> PT sstp-client.src: W: spelling-error %description -l en_US pon -> pin, pom, on sstp-client.src: W: spelling-error %description -l en_US poff -> off, toff, poof 4 packages and 0 specfiles checked; 2 errors, 8 warnings.
E: missing-call-to-setgroups-before-setuid /usr/sbin/sstpc
It should be easy to fix, but I haven't been programming in C for years and I reported it upstream: https://sourceforge.net/p/sstp-client/discussion/1499217/thread/d1508589/
sstp-client.x86_64: E: missing-call-to-chdir-with-chroot /usr/sbin/sstpc
It's strange as there is a chdir() call: https://sourceforge.net/p/sstp-client/code/200/tree/trunk/src/sstp-util.c#l3...
W: only-non-binary-in-usr-lib
There is just a symlink to .so file from the main package
W: dangerous-command-in-%postun rm
It seems to be required for clean up after %pre operations - maybe it can be simplified somehow?