Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: tpm-tools - TPM management utilities
https://bugzilla.redhat.com/show_bug.cgi?id=394941
------- Additional Comments From key@linux.vnet.ibm.com 2007-12-14 14:01 EST ------- (In reply to comment #3)
For 1.3.1-2:
- SourceURL
- Perhaps the correct one is http://downloads.sourceforge.net/trousers/%%7Bname%7D-%%7Bversion%7D.tar.gz
Yep, I'll fix.
- Redundant Requires A. "Requires: trousers" is not needed
- rpmbuild checks the dependency for libraries. For this package tpm-tools binary rpm requires libtspi.so.1 and this dependency should pull trousers automatically.
ok
B. Requires(post/postun): /sbin/ldconfig For this package this is not needed because
%post -p /sbin/ldconfig %postun -p /sbin/ldconfig
automatically adds these dependencies.
ok
? configure option
- (This is a question) Would you explain why you want "--disable-pkcs11-support"?
pkcs11 support requires the opencryptoki package, which hasn't been submitted. If at some future time we submit that, we could enable this support.
- Directory ownership issue
%files devel %{_includedir}/tpm_tools/*.h
- This causes
[tasaka1@localhost ~]$ LANG=C rpm -qf /usr/include/tpm_tools/ file /usr/include/tpm_tools is not owned by any package
Ok, I'll add /usr/include/tpm_tools as I did in the trousers spec file.
Kent