[Bug 2244124] Review Request: crow-translate - A simple and lightweight translator
https://bugzilla.redhat.com/show_bug.cgi?id=2244124
--- Comment #17 from Artem <ego.cordatus(a)gmail.com> ---
(In reply to Robert-André Mauchin 🐧 from comment #16)
These directory are uncommon and are not owned by hicolor-icon-theme.
Own them in your SPEC.
This look like unnecessary files. I removed them for now and opened upstream
issue https://github.com/crow-translate/crow-translate/issues/685. Waiting for
upstream approval.
Seek a FPC exception for bundling 3rd party libraries, or package
them. Nothing prevents you from doing it but you'all to modify the CMakelists. For
example:
Fedora guidelines says:
Fedora packages SHOULD make every effort to avoid having multiple,
separate, upstream projects bundled together in a single package.
Not MUST. And i already asked about this upstream. Also documented in Spec.
Upstream answer is:
Consider submodules in this repo as a way to avoid copy-pasting the
code
I don't want patching this downstream and i don't want fight with upstream.
I've already learned this lesson. If someone really wants this please submit
upstream patch.
https://docs.fedoraproject.org/en-US/packaging-guidelines/#bundling
---
New build:
https://download.copr.fedorainfracloud.org/results/atim/playground/fedora...
https://download.copr.fedorainfracloud.org/results/atim/playground/fedora...
--
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2244124
Report this comment as SPAM:
https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=rep...