https://bugzilla.redhat.com/show_bug.cgi?id=1858531
--- Comment #4 from Luya Tshimbalanga luya_tfz@thefinalzone.net --- (In reply to Robert-André Mauchin 🐧 from comment #1)
- Please fix the Source0:
Source0: https://github.com/wdas/%%7Bname%7D/archive/v%%7Bversion%7D/%%7Bname%7D-%%7B...
(archives → archive)
Fixed.
- That should be in the Python subpackage:
%{python3_sitearch}/_%{name}.so
Fixed,
(Probably something like that:
set_target_properties(partio PROPERTIES OUTPUT_NAME partio POSITION_INDEPENDENT_CODE ON VERSION ${VERSION} SOVERSION 1 )
in src/lib/CMakeLists.txt)
After applying a patch using the above code, the build managed to build as seen on the scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=47414693
I filed a ticket to upstream about the versioning libraries: https://github.com/wdas/partio/issues/82
- You should not provide %license LICENSE for all packages, but for all
packages combination. For ex, -devel depends on the main package which already provide the license, so it shouldn't be included another time in the -devel subpackage. Same with -doc subpackage.
Fixed.
- Is it useful to package the tests? Are they used by the end-user?
Those tests aren't need so they are removed.
- Add Version-Release to your changelog entry.
Done.
Here is the updated files: SPEC: https://download.copr.fedorainfracloud.org/results/luya/openshadinglanguage/... SRPM: https://download.copr.fedorainfracloud.org/results/luya/openshadinglanguage/...