[Bug 887913] Review Request: perl-Math-Clipper - Polygon clipping in 2D

[Red Hat Bugzilla]

Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=887913

Petr Pisar  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|fedora-review?              |
              Flags|                            |fedora-review+

--- Comment #14 from Petr Pisar  ---
This is rebase, doing review from scratch.

URL and Source0 are useable. ok.
Source tar ball is original (SHA-256:
fadd8d60a1499ae584f3d587475d27a01f4679249c1050f5307d71c09095c684). Ok.
Patch to build against system library is Ok.
Summary is Ok.
Description is Ok.
License verified from lib/Math/Clipper.pm. Ok.
There is XS code, architecture specific BuildArch is Ok.

TODO: You can replace %{__perl} macro with plain perl command.
TODO: You can remove `perl(Module::Build)' from build-requires as there is no
direct use of the module (the build is driven by Module::Build::WithXSpp).

All tests pass. Ok.

$ rpmlint perl-Math-Clipper.spec ../SRPMS/perl-Math-Clipper-1.17-1.fc19.src.rpm
../RPMS/x86_64/perl-Math-Clipper-*1.17-1.*
3 packages and 1 specfiles checked; 0 errors, 0 warnings.
rpmlint is Ok.

$ rpm -q -lv -p ../RPMS/x86_64/perl-Math-Clipper-1.17-1.fc19.x86_64.rpm
drwxr-xr-x    2 root    root                        0 Jan 17 14:43
/usr/lib64/perl5/vendor_perl/Math
-rw-r--r--    1 root    root                    24978 Jan 17 14:43
/usr/lib64/perl5/vendor_perl/Math/Clipper.pm
drwxr-xr-x    2 root    root                        0 Jan 17 14:43
/usr/lib64/perl5/vendor_perl/auto/Math
drwxr-xr-x    2 root    root                        0 Jan 17 14:43
/usr/lib64/perl5/vendor_perl/auto/Math/Clipper
-rwxr-xr-x    1 root    root                    36536 Jan 17 14:43
/usr/lib64/perl5/vendor_perl/auto/Math/Clipper/Clipper.so
drwxr-xr-x    2 root    root                        0 Jan 17 14:43
/usr/share/doc/perl-Math-Clipper-1.17
-rw-r--r--    1 root    root                     3522 Jan 15 14:09
/usr/share/doc/perl-Math-Clipper-1.17/Changes
-rw-r--r--    1 root    root                     8790 Jan 17 14:43
/usr/share/man/man3/Math::Clipper.3pm.gz
File permissions and layout are Ok.

$ rpm -q --requires -p ../RPMS/x86_64/perl-Math-Clipper-1.17-1.fc19.x86_64.rpm
|sort | uniq -c
      1 libc.so.6()(64bit)
      1 libc.so.6(GLIBC_2.2.5)(64bit)
      1 libgcc_s.so.1()(64bit)
      1 libgcc_s.so.1(GCC_3.0)(64bit)
      1 libpolyclipping.so.5()(64bit)
      1 libstdc++.so.6()(64bit)
      1 libstdc++.so.6(CXXABI_1.3)(64bit)
      1 libstdc++.so.6(GLIBCXX_3.4)(64bit)
      1 perl >= 0:5.008
      1 perl(Carp)
      1 perl(Config)
      1 perl(Exporter)
      1 perl(:MODULE_COMPAT_5.16.2)
      1 perl(strict)
      1 perl(warnings)
      1 perl(XSLoader)
      1 rpmlib(CompressedFileNames) <= 3.0.4-1
      1 rpmlib(FileDigests) <= 4.6.0-1
      1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
      1 rpmlib(PayloadIsXz) <= 5.2-1
      1 rtld(GNU_HASH)
Binary requires are Ok.

$ rpm -q --provides -p ../RPMS/x86_64/perl-Math-Clipper-1.17-1.fc19.x86_64.rpm
|sort | uniq -c
      1 perl(Math::Clipper) = 1.17
      1 perl-Math-Clipper = 1.17-1.fc19
      1 perl-Math-Clipper(x86-64) = 1.17-1.fc19
Binary provides are Ok.

$ resolvedeps rawhide ../RPMS/x86_64/perl-Math-Clipper-1.17-1.fc19.x86_64.rpm 
Binary dependencies resolvable. Ok.

Package builds in F19
(http://koji.fedoraproject.org/koji/taskinfo?taskID=4878183). Ok.

Package is in line with Fedora and Perl packaging guidelines.

Please fix all `TODO' items before building the package.
Resolution: Package APPROVED.