Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=803082
Michael Scherer misc@zarb.org changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |misc@zarb.org AssignedTo|nobody@fedoraproject.org |misc@zarb.org Flag| |fedora-review?
--- Comment #2 from Michael Scherer misc@zarb.org 2012-03-19 08:53:05 EDT --- Hi,
A few comments : - desktop-file-validate %{buildroot}/%{_datadir}/applications/%{name}.desktop
If you use $RPM_BUILD_ROOT, you should use it here too, ot use %{buildroot} in the beginning
https://fedoraproject.org/wiki/Packaging:Guidelines#Using_.25.7Bbuildroot.7D...
- %%doc COPYING NEWS README Is this normal to have %% instead of % ?
- the patch comment should have a link to upstream bug report, and explain more why it is needed.
https://fedoraproject.org/wiki/Packaging:Guidelines#All_patches_should_have_...
- I am not sure that mentioning en %description file formats not supported out of the box ( per licensing reason ) is a good idea. This is kinda misleading.