https://bugzilla.redhat.com/show_bug.cgi?id=1291021
Zbigniew Jędrzejewski-Szmek zbyszek@in.waw.pl changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |zbyszek@in.waw.pl Assignee|nobody@fedoraproject.org |zbyszek@in.waw.pl Flags| |fedora-review?
--- Comment #1 from Zbigniew Jędrzejewski-Szmek zbyszek@in.waw.pl --- - software is under an acceptable license (BSD with adv.) - latest (git) snapshot - license file is wrong, but upstream has been notified - no scriptlets - requires/provides are OK - new python packaging template is used - builds and installs OK - fedora-review is happy
You can drop '%doc README.md', the README is essentially empty.
There's a compiled binary repo in the archive, remove it in %prep to be sure it's not packaged by mistake.
Add %check: %{buildroot}%{_bindir}/debruijn 12 3
It seems fairly easy to crash it by specifying sufficiently large values: $ debruijn 12 8 terminate called after throwing an instance of 'std::bad_alloc' what(): std::bad_alloc Aborted (core dumped)
valgrind in general is not too happy with the binary ;)
rpmlint: debruijn.i686: W: spelling-error Summary(en_US) de -> DE, ed, d debruijn.i686: W: spelling-error Summary(en_US) neuroscience -> pseudoscience debruijn.i686: W: spelling-error %description -l en_US de -> DE, ed, d debruijn.i686: W: spelling-error %description -l en_US neuroscience -> pseudoscience rpmlint is prescient!
debruijn.i686: W: no-manual-page-for-binary debruijn debruijn.src: W: spelling-error Summary(en_US) de -> DE, ed, d debruijn.src: W: spelling-error Summary(en_US) neuroscience -> pseudoscience debruijn.src: W: spelling-error %description -l en_US de -> DE, ed, d debruijn.src: W: spelling-error %description -l en_US neuroscience -> pseudoscience debruijn-debuginfo.i686: W: spurious-executable-perm /usr/src/debug/DeBruijn-1563f6f8833d88b7cde399cbf93f35b8b4b81586/debruijn.cpp debruijn-debuginfo.i686: W: spurious-executable-perm /usr/src/debug/DeBruijn-1563f6f8833d88b7cde399cbf93f35b8b4b81586/debruijn.h 3 packages and 0 specfiles checked; 0 errors, 11 warnings.
All OK.