[Bug 226795] Review Request: sdcc - Small Device C Compiler

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: sdcc - Small Device C Compiler

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=226795

------- Additional Comments From [e-mail]  2007-02-27 05:49 EST -------
(In reply to comment #25)
> MUST fix:
> put all the files under /usr/share/sdcc/lib/src and the .asm files under
> /usr/share/sdcc/lib/* in a seprate -src subpackage. AFAIK these files are only
> needed when one wants to look at the innerworkings of the C-library and are 
> not needed for normal development, thus they shouldn't be part of the base
> package.

FIXED.
> Remove the "Requires:       gc" from the specfile, gc is a lib and an
> automatic dependency on the needed .so file will be generated.

FIXED.
> We all agree a -devel package is bogus so remove the devel subpackage instead
> of just commenting it
> sdcc's make install installs the docs under /usr/share/sdcc/doc, they
> should be installed under /usr/share/doc/sdcc-%{version} using %doc
> Tip: after the "make install" do:
> mv $RPM_BUILD_ROOT%{_datadir}/%{name}/doc installed-docs
> and then to %files add "%doc installed-docs/*"

FIXED.
> You must own the sdcc dirs the package create, under %files don't write:
> %{_libexecdir}/sdcc/*
> %{_datadir}/sdcc/*
> But write:
> %{_libexecdir}/%{name}
> %{_datadir}/%{name}
> Then the package will also own the %{_datadir}/sdcc and %{_libexecdir}/sdcc
> dirs

FIXED.
> You must also own %{_datadir}/emacs as that is not a standard dir, easiest way
> todo this is to just write %{_datadir}/emacs under %files instead of
> %{_datadir}/emacs/site-lisp/*

FIXED.

The Source URL has also been updated according to the guidelines in the wiki.
STRIP=: has also been added to %configure as suggested in #23. The debuginfo
package is still created though...

Updated spec and srpm files are here: ftp://open-gnss.org/pub/fedora/sdcc/