https://bugzilla.redhat.com/show_bug.cgi?id=1607091
--- Comment #2 from Tomáš Hozza thozza@redhat.com --- Thanks for review.
(In reply to Robert-André Mauchin from comment #1)
- Use a more meaningful name for your archive with:
Source0: %url/archive/v%{version}/%{name}-%{version}.tar.gz
I was not sure how to fixed this with github. I fixed this to download the archive using the name of the upstream project, not the package, to reduce confusion.
- %setup v%{version}.tar.gz -n gnome-extension-taskwarrior-%{version}
Use %autosetup -n gnome-extension-taskwarrior-%{version}
I changed this, although %setup vs. %autosetup is a thing of maintainer preference.
%dir %{gnome_extensions_dir}/%{uuid} %{gnome_extensions_dir}/%{uuid}/*
Simply use instead:
%{gnome_extensions_dir}/%{uuid}
This is cosmetic change. Yes, SPEC is shorter, but I take the %dir to be more explicit. Nevertheless I changed it.
- Split the description to stay below 80 characters per line:
gnome-shell-extension-taskwarrior.noarch: E: description-line-too-long C This GNOME shell extension is enabling access to Taskwarrior from the gnome shell taskbar.
Done.
I updated SPEC, SRPM and COPR: Spec URL: https://thozza.fedorapeople.org/gnome-shell-extension-taskwarrior/gnome-shel... SRPM URL: https://thozza.fedorapeople.org/gnome-shell-extension-taskwarrior/gnome-shel...