Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: lua-filesystem - File System Library for Lua
https://bugzilla.redhat.com/show_bug.cgi?id=440676
tibbs@math.uh.edu changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+
------- Additional Comments From tibbs@math.uh.edu 2008-04-04 19:10 EST ------- Yes, debuginfo is OK now.
Do note that I see the following unpleasant compiler warnings:
src/lfs.c: In function 'get_dir': src/lfs.c:112: warning: implicit declaration of function 'free' src/lfs.c:112: warning: incompatible implicit declaration of built-in function 'free'
which will probably cause a build failure if we ever turn on -Werror-implicit-function-declaration by default.
Do note also that your passing of CFLAGS disables the default -I arguments that the makefile passes. It turns out that it's only /usr/include so you should be OK.
Anyway, everything looks acceptable now. APPROVED