https://bugzilla.redhat.com/show_bug.cgi?id=2237820
Neal Gompa ngompa13@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |POST CC| |ngompa13@gmail.com Flags| |fedora-review+ Assignee|nobody@fedoraproject.org |ngompa13@gmail.com
--- Comment #5 from Neal Gompa ngompa13@gmail.com --- Review notes:
* Package follows packaging guidelines * Package builds and installs properly * Package licensing is correct and license files are collected
One suggestion: Consider converting the BRs to pkgconfig() deps as it seems the CMake scripts look for dependencies via pkgconfig
Otherwise, this is good to go...
PACKAGE APPROVED.