Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: cobbler
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=192311
------- Additional Comments From mdehaan@redhat.com 2006-08-16 17:09 EST ------- """ Source0: does not contain a URL to the upstream tarball. I'd consider this a blocker unless somehow there is no upstream other than this package. """
I am the upstream; the SRPM is canonical. This app is not expected to work outside of RHEL4+/FC5+ without modification. Seeing it includes kickstart features (which are already very distro specific) that shouldn't be a problem.
--------------
"Really odd for the sticky bit to be set on a spec file."
Fixed.
--------------
""" W: cobbler setup-not-quiet Not a big deal; pass -q to the %setup macro if you want to quiet this. """
Fixed.
----------------------------
""" cobbler non-executable-script /usr/lib/python2.4/site-packages/cobbler/gui.py 0644 """
Fixed. That file should not have been in the release.
--------------------
rpmlint on both RPM's yields no output at this point and unit tests pass.
New versions:
http://et.redhat.com/~mdehaan/software/cobbler/cobbler-0.1.1-5.src.rpm http://et.redhat.com/~mdehaan/software/cobbler/cobbler-0.1.1-5.noarch.rpm