https://bugzilla.redhat.com/show_bug.cgi?id=2282807
Michel Lind michel@michel-slm.name changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+
--- Comment #13 from Michel Lind michel@michel-slm.name --- nit: (MIT OR Zlib OR Apache-2.0) is a duplicate of (MIT OR Zlib OR Apache-2.0) preceding it, so is (Zlib OR Apache-2.0 OR MIT) towards the end. Not a blocker though, you can fix when importing
If you're not already doing so, consider using rust2rpm.toml for the additional build requirements, it will help when regenerating the spec.
e.g.
[requires] build = [ "libpq-devel", "mariadb-devel", "openssl-devel", "systemd-rpm-macros", ]
You can automate the additional steps in %build and %install as well - man rust2rpm.toml, see "[scripts] table"
Package was generated with rust2rpm, simplifying the review.
- package builds and installs without errors on rawhide - test suite is run and all unit tests pass - latest version of the crate is packaged - license matches upstream specification (MIT OR Apache-2.0) and is acceptable for Fedora - [BINARY ONLY] licenses of statically linked dependencies are correctly taken into account - license file is included with %license in %files - package complies with Rust Packaging Guidelines
Package APPROVED.
===
Recommended post-import rust-sig tasks (use `fedora-sig-onboard onboard rust-$crate` to automate): * fedora-sig-onboard might not actually work for packages not prefixed with 'rust-', if it does not please file a bug
- add @rust-sig with "commit" access as package co-maintainer (should happen automatically)
- set bugzilla assignee overrides to @rust-sig (optional)
- set up package on release-monitoring.org: project: $crate homepage: https://crates.io/crates/$crate backend: crates.io version scheme: semantic version filter: alpha;beta;rc;pre distro: Fedora Package: rust-$crate
- track package in koschei for all built branches (should happen automatically once rust-sig is co-maintainer)