Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Re-Review Request: jed: an editor
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=189374
tibbs@math.uh.edu changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|bugzilla-sink@leemhuis.info |tibbs@math.uh.edu OtherBugsDependingO|163776 |163778 nThis| |
------- Additional Comments From tibbs@math.uh.edu 2006-06-02 13:57 EST ------- Just did a quick mock build (development, x86_64). rpmlint is unhappy:
W: jed prereq-use /sbin/install-info
I see the Prereq: but I don't see any calls to install-info. The scriptlets at http://fedoraproject.org/wiki/ScriptletSnippets?highlight=%28scriptlets%29#h... should be used to install info pages; Prereq: should not be used in any case; Requires(pre): is preferred.
W: jed buildprereq-use slang-devel >= 2.0, autoconf, libselinux-devel
BuildRequires: should be used instead.
E: jed broken-syntax-in-scriptlet-requires BuildPrereq: slang-devel >= 2.0, autoconf, libselinux-devel
Not sure what's up here; it will probably go away when you switch to BuildRequires:
W: jed hardcoded-path-in-buildroot-tag /var/tmp/%{name}-%{version}-%{release}-root
Please use %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n) as the buildroot.
W: jed patch-not-applied Patch3: jed-multilib.patch
I assume you have reasons for not applying patch3.
E: jed obsolete-not-provided jed-common E: jed obsolete-not-provided jed-xjed
You should provide these so that upgrades work and so that any packages which might depend on them don't break.
E: jed binary-or-shlib-defines-rpath /usr/bin/jed ['/usr/lib64']
rpath is bad and should be removed if at all possible. I'll dig into this further if necessary.
W: jed doc-file-dependency /usr/share/doc/jed-0.99.18/doc/tm/rtl/tm-sort.sl /usr/bin/env W: jed doc-file-dependency /usr/share/doc/jed-0.99.18/doc/tm/rtl/whatelse.sl /usr/bin/env
Documentation should not be executable.