Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: postgresql-plr - Procedural language interface between PostgreSQL and R
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=246782
kaigai@kaigai.gr.jp changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |kaigai@kaigai.gr.jp
------- Additional Comments From kaigai@kaigai.gr.jp 2007-08-24 11:18 EST ------- The following comments are based on the Package Review Guidelines and the Packaging Guidelines. But I'm not a sponsor of the Fedora project, so these are not official review comments.
- You should post the result of rpmlint command. Just I tried to run rpmlint for the binary package which I built, so it generate no errors/warnnings.
- You should confirm the license of the package. "BSD" is put on the License: tag in the specfile, but plr/README.plr in the source tree says this software distributed under GPLv2 or later.
- You should own the directories on which this package creates, such as % {_datadir}/%{name} and %{_docdir}/%{name}-%{version}
- You should use -p option with install command to preserve timestamps.
- You should add the R package into BuildRequires: tag, because the package obviously uses /usr/lib/R/include/R.h to build.
- You should apply common compiler flags defined as $RPM_OPT_FLAGS or % {optflags}. (See, http://fedoraproject.org/wiki/Packaging/Guidelines#head- 8b14098227aebff1cf6188939e9d0877295ac448) -
[Package Review Guidelines] http://fedoraproject.org/wiki/Packaging/ReviewGuidelines
[The Packaging Guidelines] http://fedoraproject.org/wiki/Packaging/Guidelines)