https://bugzilla.redhat.com/show_bug.cgi?id=1671571
Justin W. Flory jflory7@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags| |needinfo?(dridi.boukelmoune | |@gmail.com)
--- Comment #30 from Justin W. Flory jflory7@gmail.com --- Hi, a few changes:
1. Updated package to latest upstream release, v2.0.2 2. Implemented feedback from fedora-review tool 3. Updated package successfully built in COPR [1] and Koji [2][3][4]
The updated RPM SPEC and SRPM are below and ready for review:
SPEC URL: https://pagure.io/jflory7-rpm-specs/raw/master/f/rpmbuild/SPECS/playerctl.sp... SRPM URL: https://pagure.io/jflory7-rpm-specs/raw/master/f/rpmbuild/SRPMS/playerctl-2....
As for packaging the static library, I do not know how to work around not including it. I reviewed the packaging guidelines and they do not mention a requirement to get an exception to ship the static library, only that the static library should be packaged separately:
https://docs.fedoraproject.org/en-US/packaging-guidelines/#_packaging_static...
I ran this through fedora-review this time before I created this SRPM. Let me know if anything is left for this package review.
--- [1] https://copr.fedorainfracloud.org/coprs/jflory7/playerctl/build/881174/ [2] https://koji.fedoraproject.org/koji/taskinfo?taskID=34085414 [3] https://koji.fedoraproject.org/koji/taskinfo?taskID=34085407 [4] https://koji.fedoraproject.org/koji/taskinfo?taskID=34085421