Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: ardour
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=189315
------- Additional Comments From seg@haxxed.com 2006-08-05 19:34 EST ------- MUST items:
- rpmlint: Ok - Package name: Ok - Spec name: Ok - Meets packaging guidelines: Ok - License: Ok - Spec in American English: Ok - Spec legible: Ok - Sources match upstream: Ok - Builds: Ok - BuildRequires: Ok - Locales: Ok - ldconfig: Ok - Relocation: Ok - Directory ownership: Ok - %files: Ok - %clean: Ok - Macros: Ok - Code vs. Content: Ok - Documentation: Ok - devel package: Ok - .desktop file: Ok
SHOULD:
- Includes license text: Ok - Mock build: Ok - Builds on all archs: Built on i386, x86_64 - Package functional: Tested on i386, x86_64 - Scriptlets: Ok - Subpackages: Ok
NEEDSWORK:
Just noticed the desktop entry is embedded in the spec. Putting it in a file and sourcing it would be preferable.
Other than that, looks good.