Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=541589
--- Comment #1 from Lubomir Rintel lkundrak@v3.sk 2009-11-26 15:53:45 EDT --- 0.) The -javadoc subpackage should requires jpackage-utils ...that owns %_javadocdir
1.) Does not build you probably meant to add junit4 to the classpath
2.) You don't use macros consistently please use either $RPM_BUILD_ROOT or %{buildroot} macro but not both
The rest is just matter of clean style. Just for your considerations, probably nothing that would block the review:
You can do this in one shot, without calling rm: -find -name '*.class' -exec rm -f '{}' ; -find -name '*.jar' -exec rm -f '{}' ; +find ( -name '*.class' -o -name '*.jar' ) -delete