https://bugzilla.redhat.com/show_bug.cgi?id=1944764
--- Comment #3 from Jan Drögehoff sentrycraft123@gmail.com --- (In reply to Robert-André Mauchin 🐧 from comment #1)
- Please don't use macro prefixed by two underscore, they are reserved for
RPM private use:
%{__mkdir_p} → mkdir -p
I was unaware of that and will change
- You need to verify the %{_datadir}/applications/sameboy.desktop file. See
https://docs.fedoraproject.org/en-US/packaging-guidelines/ #_desktop_file_install_usage
Correct I had forgotten to add that when removing the desktop-file-install for the base dekstop while dealing with the name change
- I would rename the name and spec filename to sameboy all lowercase
This was a mistake on my part I had misread the guidelines (or perhaps even read an older version, I am unsure) and named it the same way it was called everywhere publicly
- You need to own %{_datadir}/%{name}
Already present in the spec submitted
and %{_datadir}/%{name}/Shaders
%dir %{_datadir}/%{name}/Shaders
(But you can just include the whole %{_datadir}/%{name} instead of listing all files under that directory).
see above
- You need to be more specific than this:
%{_datadir}/icons/hicolor/
→
%{_datadir}/icons/hicolor/*/apps/*.png
And then Requires: hicolor-icon-theme to own the icons directories.
- Use a more explicit name for your archive:
Source0: https://github.com/LIJI32/SameBoy/archive/v%%7Bversion%7D/%%7Bname%7D-%%7Bve.... gz
I was unaware github allowed to download from an arbritary path
But as I said it is not possible to package this in Fedora as the ROM are non-free. Try proposing them to RPMFusion non-free repos. I also think this shouldn't be in COPR https://copr.fedorainfracloud.org/coprs/sentry/sameboy/ as it is non-free
I am making this is a follow-up comment, refer to comment #2