Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: buildbot
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=197565
------- Additional Comments From giallu@gmail.com 2006-07-26 17:41 EST ------- (In reply to comment #9)
It doesn't like Gianluca has the access necessary for doing reviews;
Sorry for lurking on this. Rex is true: AFAIK official reviews leading to ACCEPTED status are meant to be made from any current package owner or SPONSORS (in case this is your first package). Unfortunately, I do not belong to either group :(
From reading the above comments (as I haven't built the package), the rpmlint warnings stand out:
W: buildbot wrong-file-end-of-line-encoding /usr/share/doc/buildbot-0.7.3/contrib/windows/buildbot2.bat
What's the point of including the windows bits at all?
W: buildbot doc-file-dependency /usr/share/doc/buildbot-0.7.3/contrib/run_maxq.py /usr/bin/env W: buildbot doc-file-dependency /usr/share/doc/buildbot-0.7.3/contrib/svn_buildbot.py /usr/bin/env
Documentation shouldn't be executable.
maybe the whole "contrib" directory can go in /usr/share/buildbot (along the line of /usr/share/cvs/contrib/), since those are support scripts and not really documentation.
One last remark: I can not recall where I read it, but I believe it is recommended to not repeat the name of the package in the Summary field.