Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=506232
Orcan 'oget' Ogetbil oget.fedora@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |oget.fedora@gmail.com AssignedTo|nobody@fedoraproject.org |oget.fedora@gmail.com Flag| |fedora-review?
--- Comment #1 from Orcan 'oget' Ogetbil oget.fedora@gmail.com 2009-07-02 23:29:17 EDT --- Here's my review for this:
* Buildroot doesn't obey the guidelines: http://fedoraproject.org/wiki/Packaging/Guidelines#BuildRoot_tag
* The source files claim GPLv2+ but the COPYING file says GPLv3. This software cannot be GPLv3 because it links to kdebase-workspace which is GPLv2. GPLv2 and GPLv3 don't go very well together. See: http://fedoraproject.org/wiki/Licensing#GPL_Compatibility_Matrix The license tag should be GPLv2+ but please ask upstream and verify this. Also, please don't package the false COPYING file.
* Source0 must be given in full URL. See: https://fedoraproject.org/wiki/Packaging/SourceURL#Referencing_Source
* build.log says NOTE: msgfmt not found. Translations will *not* be installed You need to add gettext to BR.
! Please make the description span 80 columns (as much as possible).
* Packages containing GUI applications must include a %{name}.desktop file, and that file must be properly installed with desktop-file-install in the %install section. Follow: http://fedoraproject.org/wiki/Packaging/Guidelines#Desktop_files Also, rpmlint says: rekonq.x86_64: E: invalid-desktopfile /usr/share/applications/kde4/rekonq.desktop
* ScriptletSnippets aren't used properly. Follow: http://fedoraproject.org/wiki/Packaging/ScriptletSnippets
! Please use the %{name} macro extensively for consistency
* A package must own all directories that it creates. If it does not create a directory that it uses, then it should require a package which does create that directory. Currently, package does not own %{_kde4_appsdir}/rekonq/ . You can replace %{_kde4_appsdir}/rekonq/rekonqui.rc %{_kde4_appsdir}/rekonq/pics/loading.gif %{_kde4_appsdir}/rekonq/defaultbookmarks.xbel %{_kde4_appsdir}/rekonq/htmls/notfound.html %{_kde4_appsdir}/rekonq/pics/webkit-icon.png with just %{_kde4_appsdir}/%{name}/ to deal with this issue.
? You are using versioned BR. Why are you not using the corresponding versioned R?
! Also the versions you use for BRs do not match what CMakeLists.txt file says.